yamt commented on code in PR #1638: URL: https://github.com/apache/nuttx-apps/pull/1638#discussion_r1137324905
########## interpreters/Wasm.mk: ########## @@ -21,9 +21,14 @@ ifeq ($(WASM_BUILD),y) ifneq ($(CONFIG_INTERPRETERS_WAMR)$(CONFIG_INTERPRETERS_WAMR3),) -WASM_INITIAL_MEMORY ?= 65536 -STACKSIZE ?= $(CONFIG_DEFAULT_TASK_STACKSIZE) -PRIORITY ?= SCHED_PRIORITY_DEFAULT +STACKSIZE ?= $(CONFIG_DEFAULT_TASK_STACKSIZE) +PRIORITY ?= SCHED_PRIORITY_DEFAULT + +ifneq ($(INITMEMORY),) + ifeq ($(shell test $(INITMEMORY) -lt $(STACKSIZE); echo $$?),0) + INITMEMORY := $(shell expr $(STACKSIZE) + $(INITMEMORY)) Review Comment: sorry, i don't understand your logic. if a developer specified INITMEMORY < STACKSIZE, i'd assume it was a mistake. do you have counter examples? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
