pkarashchenko commented on code in PR #8852:
URL: https://github.com/apache/nuttx/pull/8852#discussion_r1142008319
##########
drivers/eeprom/spi_xx25xx.c:
##########
@@ -392,6 +393,7 @@ static void ee25xx_waitwritecomplete(struct ee25xx_dev_s
*priv)
/* Deselect the FLASH */
SPI_SELECT(priv->spi, SPIDEV_EEPROM(0), false);
+ ee25xx_unlock(priv->spi);
Review Comment:
Maybe can additionally change the function prototype to take `spi` as a
parameter and not `priv` since nothing except `priv->spi` is used in the
function body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]