pkarashchenko commented on code in PR #1623:
URL: https://github.com/apache/nuttx-apps/pull/1623#discussion_r1183693741


##########
logging/nxscope/nxscope_chan.c:
##########
@@ -364,7 +364,7 @@ static int nxscope_put_vector(FAR uint8_t *buff, uint8_t 
type, FAR void *val,
 
           DEBUGASSERT(val);
 
-          strncpy((FAR char *)buff, (FAR const char *)val, d);
+          strlcpy((FAR char *)buff, (FAR const char *)val, d);

Review Comment:
   do we still need `strnlen` if we use `strlcpy`? Maybe we can use `strlen` 
instead now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to