xiaoxiang781216 commented on code in PR #1788: URL: https://github.com/apache/nuttx-apps/pull/1788#discussion_r1224623933
########## nshlib/nsh_alias.c: ########## @@ -47,22 +47,14 @@ #define alias_head(list) (FAR struct nsh_alias_s *)sq_peek(list) #define alias_remfirst(list) (FAR struct nsh_alias_s *)sq_remfirst(list) -/**************************************************************************** - * Private Types - ****************************************************************************/ - -/**************************************************************************** - * Private Data - ****************************************************************************/ - /* Alias message format */ -static const char g_aliasfmt[] = "alias %s='%s'\n"; -static const char g_savefailfmt[] = "alias %s='%s' failed\n"; +#define alias_format "alias %s='%s'\n" Review Comment: should we keep g_ prefix like g_dd? ########## nshlib/nsh_console.h: ########## @@ -58,6 +58,15 @@ # define nsh_output vtbl->output #endif +#ifdef CONFIG_NSH_DISABLE_ERROR_PRINT +# undef nsh_error Review Comment: two space indent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
