pussuw commented on PR #9577: URL: https://github.com/apache/nuttx/pull/9577#issuecomment-1655999466
> > > @pussuw please fix the style warning. > > > > > > @xiaoxiang781216 I don't think I'm responsible for the style issue: Error: /home/runner/work/nuttx/nuttx/nuttx/sched/misc/assert.c:243:18: error: Unmatched right parentheses Error: /home/runner/work/nuttx/nuttx/nuttx/sched/misc/assert.c:276:18: error: Unmatched right parentheses Error: Process completed with exit code 1. > > It is the same as in here #9824 > > I thought the style check would not complain about issues that are already in upstream ? > > No, the style checks the full source code. This design prefers the contributor fix the style issue in the old code base. But I'm still confused, the only change I made in assert.c is `static uintptr_t g_last_regs[XCPTCONTEXT_REGS] aligned_data(16);` The violation comes from a previous very recent commit (#9824), which was merged with the violation. The code added there is fine so I think the violation is a false alarm, but I have NO IDEA how to fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
