xiaoxiang781216 commented on code in PR #2076: URL: https://github.com/apache/nuttx-apps/pull/2076#discussion_r1331958128
########## testing/ostest/spinlock.c: ########## @@ -0,0 +1,85 @@ +/**************************************************************************** + * apps/testing/ostest/spinlock.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdio.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/spinlock.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static spinlock_t lock = SP_UNLOCKED; + +static pthread_t g_thread1; +static pthread_t g_thread2; + +static int g_result = 0; + +static FAR void thread_spinlock(FAR void *parameter) +{ + for (int i = 0; i < 10; i++) + { + spin_lock(&lock); + g_result++; + spin_unlock(&lock); + } +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +void spinlock_test(void) +{ + int status; + + status = pthread_create(&g_thread1, NULL, (void *)thread_spinlock, NULL); + if (status != 0) + { + printf("spinlock_test: ERROR pthread_create failed, status=%d\n", + status); + ASSERT(false); + } + + status = pthread_create(&g_thread2, NULL, (void *)thread_spinlock, NULL); Review Comment: ditto ########## testing/ostest/spinlock.c: ########## @@ -0,0 +1,85 @@ +/**************************************************************************** + * apps/testing/ostest/spinlock.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdio.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/spinlock.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static spinlock_t lock = SP_UNLOCKED; + +static pthread_t g_thread1; +static pthread_t g_thread2; + +static int g_result = 0; + +static FAR void thread_spinlock(FAR void *parameter) +{ + for (int i = 0; i < 10; i++) + { + spin_lock(&lock); + g_result++; + spin_unlock(&lock); + } +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +void spinlock_test(void) +{ + int status; + + status = pthread_create(&g_thread1, NULL, (void *)thread_spinlock, NULL); Review Comment: remove `(void *)` ########## testing/ostest/spinlock.c: ########## @@ -0,0 +1,85 @@ +/**************************************************************************** + * apps/testing/ostest/spinlock.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdio.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/spinlock.h> + +#include "ostest.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static spinlock_t lock = SP_UNLOCKED; + +static pthread_t g_thread1; +static pthread_t g_thread2; + +static int g_result = 0; + +static FAR void thread_spinlock(FAR void *parameter) Review Comment: `FAR void` to `FAR void *` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
