xiaoxiang781216 commented on code in PR #11165:
URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390200245
##########
libs/libc/sched/CMakeLists.txt:
##########
@@ -26,11 +26,11 @@ set(SRCS
clock_timespec_add.c
clock_timespec_subtract.c
clock_getcpuclockid.c
- clock_getres.c)
-
-if(NOT CONFIG_CANCELLATION_POINTS)
Review Comment:
why remove the check of CONFIG_CANCELLATION_POINTS
##########
sched/tls/tls_initinfo.c:
##########
@@ -66,5 +70,17 @@ int tls_init_info(FAR struct tcb_s *tcb)
/* Attach per-task info in group to TLS */
info->tl_task = tcb->group->tg_info;
+
+ /* Initialize cancellation state */
+
+#ifdef CONFIG_CANCELLATION_POINTS
+ /* Set the deferred cancellation type */
+
+ info->tl_cpstate |= CANCEL_FLAG_CANCEL_DEFERRED;
+ info->tl_cpcount = 0; /* REVISIT: Remove this */
Review Comment:
don't need
##########
include/nuttx/tls.h:
##########
@@ -205,6 +205,12 @@ struct tls_info_s
struct pthread_cleanup_s stack[CONFIG_PTHREAD_CLEANUP_STACKSIZE];
Review Comment:
could you create a new patch adding tl_ prefix to tos and stack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
