xiaoxiang781216 commented on code in PR #2205:
URL: https://github.com/apache/nuttx-apps/pull/2205#discussion_r1400833319
##########
testing/ostest/ostest_main.c:
##########
@@ -347,13 +349,15 @@ static int user_main(int argc, char *argv[])
check_test_memory_usage();
#endif
+#ifndef CONFIG_BUILD_KERNEL
/* Checkout task_restart() */
printf("\nuser_main: task_restart test\n");
restart_test();
check_test_memory_usage();
+#endif
-#ifdef CONFIG_SCHED_WAITPID
+#if defined(CONFIG_SCHED_WAITPID) && !defined(CONFIG_BUILD_KERNEL)
/* Check waitpid() and friends */
Review Comment:
waittpid support in kernel mode, why skip
##########
testing/ostest/ostest_main.c:
##########
@@ -225,6 +225,7 @@ static int user_main(int argc, char *argv[])
printf("\nuser_main: Begin argument test\n");
printf("user_main: Started with argc=%d\n", argc);
+#ifndef CONFIG_BUILD_KERNEL
Review Comment:
why skip
##########
testing/ostest/ostest_main.c:
##########
@@ -706,6 +719,9 @@ int main(int argc, FAR char **argv)
}
printf("ostest_main: Exiting with status %d\n", ostest_result);
+#else
+ user_main(1, NULL);
Review Comment:
why need #else
##########
testing/ostest/signest.c:
##########
@@ -295,11 +298,12 @@ void signest_test(void)
/* Start interfering thread */
- prio++;
- printf("signest_test: Starting interfering task at priority %d\n", prio);
- interferepid = task_create("interfere", prio, STACKSIZE,
Review Comment:
let's change task_create to posix_spawn
##########
testing/ostest/ostest_main.c:
##########
@@ -581,8 +585,16 @@ static int user_main(int argc, char *argv[])
#endif
#if defined(CONFIG_ARCH_HAVE_FORK) && defined(CONFIG_SCHED_WAITPID)
+#ifndef CONFIG_BUILD_KERNEL
printf("\nuser_main: vfork() test\n");
vfork_test();
Review Comment:
vfork should support too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
