This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 13d6bc2 Improved: Fix issues reported by SonarQube analysis on
Github (OFBIZ-12284)
13d6bc2 is described below
commit 13d6bc291387617198d2c7268e1abf14cdfa156c
Author: Jacques Le Roux <[email protected]>
AuthorDate: Fri Aug 6 11:45:30 2021 +0200
Improved: Fix issues reported by SonarQube analysis on Github (OFBIZ-12284)
Those should be OK, for instance I see no reasons to do something like that:
window.location.href = window.location.href;
---
framework/webtools/template/entity/ModelInduceFromDb.jsp | 4 ++--
themes/common-theme/webapp/common/js/util/application.js | 2 +-
themes/common-theme/webapp/common/js/util/fieldlookup.js | 2 --
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/framework/webtools/template/entity/ModelInduceFromDb.jsp
b/framework/webtools/template/entity/ModelInduceFromDb.jsp
index f3c8240..9fe696a 100644
--- a/framework/webtools/template/entity/ModelInduceFromDb.jsp
+++ b/framework/webtools/template/entity/ModelInduceFromDb.jsp
@@ -30,14 +30,14 @@ if(security.hasPermission("ENTITY_MAINT", session)) {
<title>ModelInduceFromDB</title>
</head>
<body>
-<div class='h3'><b>Put the name of the Datasource in the EntityEngine.xml to
induce from:</b></div>
+<div class='h3'><strong>Put the name of the Datasource in the EntityEngine.xml
to induce from:</b></div>
<form action='' method="post">
<input type='text' class='inputBox' size='40' name='helperName' />
<input type='submit' value='Induce!' />
</form>
It's the datasource name. It doesn't need to be associated with a
delegator, just defined in entityengine.xml.<br/>
- <b> Use the browser to view the source and see the entities that were
created.</b>
+ <strong> Use the browser to view the source and see the entities that were
created.</b>
</body>
</html>
diff --git a/themes/common-theme/webapp/common/js/util/application.js
b/themes/common-theme/webapp/common/js/util/application.js
index fbecfef..927e752 100644
--- a/themes/common-theme/webapp/common/js/util/application.js
+++ b/themes/common-theme/webapp/common/js/util/application.js
@@ -102,7 +102,7 @@ var j = 1;
/*********************
JQuery Formalize
*********************/
-var FORMALIZE = (function($, window, document, undefined) {
+var FORMALIZE = (function($, window, document, notDefined) {
var PLACEHOLDER_SUPPORTED = 'placeholder' in
document.createElement('input');
var AUTOFOCUS_SUPPORTED = 'autofocus' in document.createElement('input');
var WEBKIT = 'webkitAppearance' in document.createElement('select').style;
diff --git a/themes/common-theme/webapp/common/js/util/fieldlookup.js
b/themes/common-theme/webapp/common/js/util/fieldlookup.js
index 47b31f4..7f6e38b 100644
--- a/themes/common-theme/webapp/common/js/util/fieldlookup.js
+++ b/themes/common-theme/webapp/common/js/util/fieldlookup.js
@@ -641,7 +641,6 @@ function lookupFormAjaxRequest(formAction, form) {
},
success : function(result) {
if (result.search(/loginform/) != -1) {
- window.location.href = window.location.href;
return;
}
// Here we are removing the spinner.
@@ -678,7 +677,6 @@ function lookupPaginationAjaxRequest(navAction, type) {
},
success : function(result) {
if (result.search(/loginform/) != -1) {
- window.location.href = window.location.href;
return;
}
// Here we are removing the spinner.
