This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push: new 2489381 Improved: Handle remaining checkstyle errors (OFBIZ-12169) 2489381 is described below commit 2489381f7fc5b79bf3419a046e1316492b484a7f Author: Jacques Le Roux <jacques.le.r...@les7arts.com> AuthorDate: Sun Oct 17 15:59:35 2021 +0200 Improved: Handle remaining checkstyle errors (OFBIZ-12169) Adds unused hashCode method to *ArtifactInfo and PackingSession classes Makes final CmsEvents, ContactMechWorker and PartyWorker classes There are no longer any checkstyle issues --- .../src/main/java/org/apache/ofbiz/content/cms/CmsEvents.java | 2 +- .../main/java/org/apache/ofbiz/party/contact/ContactMechWorker.java | 2 +- .../src/main/java/org/apache/ofbiz/party/party/PartyWorker.java | 2 +- .../main/java/org/apache/ofbiz/shipment/packing/PackingSession.java | 5 +++++ .../ofbiz/webtools/artifactinfo/ControllerViewArtifactInfo.java | 5 +++++ .../org/apache/ofbiz/webtools/artifactinfo/EntityArtifactInfo.java | 5 +++++ .../apache/ofbiz/webtools/artifactinfo/FormWidgetArtifactInfo.java | 5 +++++ .../apache/ofbiz/webtools/artifactinfo/ScreenWidgetArtifactInfo.java | 5 +++++ .../org/apache/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java | 5 +++++ .../apache/ofbiz/webtools/artifactinfo/ServiceEcaArtifactInfo.java | 5 +++++ 10 files changed, 38 insertions(+), 3 deletions(-) diff --git a/applications/content/src/main/java/org/apache/ofbiz/content/cms/CmsEvents.java b/applications/content/src/main/java/org/apache/ofbiz/content/cms/CmsEvents.java index 1605280..173ecaa 100644 --- a/applications/content/src/main/java/org/apache/ofbiz/content/cms/CmsEvents.java +++ b/applications/content/src/main/java/org/apache/ofbiz/content/cms/CmsEvents.java @@ -54,7 +54,7 @@ import org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer; /** * CmsEvents */ -public class CmsEvents { +public final class CmsEvents { private static final String MODULE = CmsEvents.class.getName(); diff --git a/applications/party/src/main/java/org/apache/ofbiz/party/contact/ContactMechWorker.java b/applications/party/src/main/java/org/apache/ofbiz/party/contact/ContactMechWorker.java index 8af207c..6590652 100644 --- a/applications/party/src/main/java/org/apache/ofbiz/party/contact/ContactMechWorker.java +++ b/applications/party/src/main/java/org/apache/ofbiz/party/contact/ContactMechWorker.java @@ -53,7 +53,7 @@ import org.apache.ofbiz.entity.util.EntityUtilProperties; /** * Worker methods for Contact Mechanisms */ -public class ContactMechWorker { +public final class ContactMechWorker { private static final String MODULE = ContactMechWorker.class.getName(); diff --git a/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyWorker.java b/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyWorker.java index c93a5b2..a9659eb 100644 --- a/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyWorker.java +++ b/applications/party/src/main/java/org/apache/ofbiz/party/party/PartyWorker.java @@ -48,7 +48,7 @@ import org.apache.ofbiz.entity.util.EntityUtil; /** * Worker methods for Party Information */ -public class PartyWorker { +public final class PartyWorker { private static final String MODULE = PartyWorker.class.getName(); diff --git a/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java b/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java index cf23f76..ba937e9 100644 --- a/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java +++ b/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java @@ -1596,5 +1596,10 @@ public class PackingSession implements java.io.Serializable { return false; } } + + @Override + public int hashCode() { + return toString().hashCode(); + } } } diff --git a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ControllerViewArtifactInfo.java b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ControllerViewArtifactInfo.java index 71b041c..2459195 100644 --- a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ControllerViewArtifactInfo.java +++ b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ControllerViewArtifactInfo.java @@ -126,6 +126,11 @@ public class ControllerViewArtifactInfo extends ArtifactInfoBase { } } + @Override + public int hashCode() { + return toString().hashCode(); + } + /** * Gets requests that this view is response to. * @return the requests that this view is response to diff --git a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/EntityArtifactInfo.java b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/EntityArtifactInfo.java index b1eb49d..f4d0058 100644 --- a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/EntityArtifactInfo.java +++ b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/EntityArtifactInfo.java @@ -103,6 +103,11 @@ public class EntityArtifactInfo extends ArtifactInfoBase { } } + @Override + public int hashCode() { + return toString().hashCode(); + } + /** * Gets entities related one. * @return the entities related one diff --git a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/FormWidgetArtifactInfo.java b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/FormWidgetArtifactInfo.java index 8405bd7..4ea7307 100644 --- a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/FormWidgetArtifactInfo.java +++ b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/FormWidgetArtifactInfo.java @@ -242,6 +242,11 @@ public class FormWidgetArtifactInfo extends ArtifactInfoBase { } } + @Override + public int hashCode() { + return toString().hashCode(); + } + /** * Gets entities used in form. * @return the entities used in form diff --git a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ScreenWidgetArtifactInfo.java b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ScreenWidgetArtifactInfo.java index 1345e64..6a65f42 100644 --- a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ScreenWidgetArtifactInfo.java +++ b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ScreenWidgetArtifactInfo.java @@ -218,6 +218,11 @@ public class ScreenWidgetArtifactInfo extends ArtifactInfoBase { } } + @Override + public int hashCode() { + return toString().hashCode(); + } + /** * Gets views referring to screen. * diff --git a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java index 3d56bdc..4cf85a6 100644 --- a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java +++ b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceArtifactInfo.java @@ -658,4 +658,9 @@ public class ServiceArtifactInfo extends ArtifactInfoBase { return false; } } + + @Override + public int hashCode() { + return toString().hashCode(); + } } diff --git a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceEcaArtifactInfo.java b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceEcaArtifactInfo.java index dd64a97..131180d 100644 --- a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceEcaArtifactInfo.java +++ b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/artifactinfo/ServiceEcaArtifactInfo.java @@ -213,4 +213,9 @@ public class ServiceEcaArtifactInfo extends ArtifactInfoBase { return false; } } + + @Override + public int hashCode() { + return toString().hashCode(); + } }