This is an automated email from the ASF dual-hosted git repository. nmalin pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push: new b3ee0ecc30 Fixed: In place editor wrong enable on display field (OFBIZ-12603) b3ee0ecc30 is described below commit b3ee0ecc30e4ccf8acc19365ebd7d7e486b0b22c Author: Nicolas Malin <nicolas.ma...@nereide.fr> AuthorDate: Fri Apr 22 15:31:50 2022 +0200 Fixed: In place editor wrong enable on display field (OFBIZ-12603) When, on a form, you set a widget-style on a display field, you activate the inline editor without reason. The issue comes from HtmlFormMacroLibrary.ftl that initialize some value in a span without control if it's necessary. --- themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl b/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl index 1272a4e67f..fc68825029 100644 --- a/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl +++ b/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl @@ -28,7 +28,7 @@ under the License. <img src="${imageLocation}" alt=""><#lt/> <#else> <#if inPlaceEditorUrl?has_content || class?has_content || alert=="true" || title?has_content> - <span data-inplace-editor-url="${inPlaceEditorUrl}" data-inplace-editor-params="${inPlaceEditorParams}" <#if idName?has_content>id="cc_${idName}"</#if> <#if title?has_content>title="${title}"</#if> <@renderClass class alert />><#t/> + <span <#if inPlaceEditorUrl?has_content>data-inplace-editor-url="${inPlaceEditorUrl}" data-inplace-editor-params="${inPlaceEditorParams}"</#if> <#if idName?has_content>id="cc_${idName}"</#if> <#if title?has_content>title="${title}"</#if> <@renderClass class alert />><#t/> </#if> <#if description?has_content>