This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 96bf0094ee Improved: Screen Classifications in Party should not show
create trigger to user with only VIEW permission (OFBIZ-12892 (#695)
96bf0094ee is described below
commit 96bf0094eea925e335301713f1c3293e15cd7dd8
Author: Pierre Smits <pierre.sm...@somonar.com>
AuthorDate: Fri Feb 16 13:58:47 2024 +0100
Improved: Screen Classifications in Party should not show create trigger to
user with only VIEW permission (OFBIZ-12892 (#695)
When accessing
https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups as a user
with only VIEW permissions (e.g. userId = auditor) the action trigger to create
a new Party Classification Group is shown.
This should not be visible to such a user as it leads to an undesired
effect and diminished user experience.
modified:
PartyClassificationScreens.xml - removed container having action trigger
PartyMenus.xml - added menu-item newPartyClassificationGroup having
permission condition
---
.../party/widget/partymgr/PartyClassificationScreens.xml | 1 -
applications/party/widget/partymgr/PartyMenus.xml | 10 ++++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/applications/party/widget/partymgr/PartyClassificationScreens.xml
b/applications/party/widget/partymgr/PartyClassificationScreens.xml
index 18d815ec22..c2e38dd798 100644
--- a/applications/party/widget/partymgr/PartyClassificationScreens.xml
+++ b/applications/party/widget/partymgr/PartyClassificationScreens.xml
@@ -109,7 +109,6 @@ under the License.
</decorator-section>
<decorator-section name="body">
<screenlet
title="${uiLabelMap.PartyClassificationGroups}">
- <container style="button-bar"><link
target="EditPartyClassificationGroup" style="buttontext create"
text="${uiLabelMap.PartyCreateNewPartyClassificationGroup}"/></container>
<container style="screenlet-body">
<include-form
name="ListPartyClassificationGroups"
location="component://party/widget/partymgr/PartyClassificationForms.xml"/>
</container>
diff --git a/applications/party/widget/partymgr/PartyMenus.xml
b/applications/party/widget/partymgr/PartyMenus.xml
index d6de61c66d..ac344b27b3 100644
--- a/applications/party/widget/partymgr/PartyMenus.xml
+++ b/applications/party/widget/partymgr/PartyMenus.xml
@@ -58,6 +58,16 @@
<parameter param-name="create_new" value="Y"/>
</link>
</menu-item>
+ <menu-item name="newPartyClassificationGroup"
title="${uiLabelMap.PartyCreateNewPartyClassificationGroup}">
+ <condition>
+ <or>
+ <if-has-permission permission="PARTYMGR" action="_CREATE"/>
+ </or>
+ </condition>
+ <link target="EditPartyClassificationGroup">
+ <parameter param-name="create_new" value="Y"/>
+ </link>
+ </menu-item>
</menu>
<menu name="PartyShortcutAppBar" title="${uiLabelMap.PartyManager}">
<menu-item name="find" title="${uiLabelMap.PartyParties}"><link
target="/partymgr/control/findparty" url-mode="inter-app"/></menu-item>
