[
https://issues.apache.org/jira/browse/OODT-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247973#comment-13247973
]
[email protected] commented on OODT-426:
----------------------------------------------------
bq. On 2012-04-04 18:34:56, Chris Mattmann wrote:
bq. > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java,
line 151
bq. > <https://reviews.apache.org/r/4628/diff/1/?file=98791#file98791line151>
bq. >
bq. > this seems like an ancillary change to this patch. However, it's a
useful functionality so I don't feel strongly about separating it out. Just be
wary of stuff like this (b/c as it grows) it can take away from the purpose of
the patch ;)
ya... thought that too when i was making the change... but i was writing the
unit-test for a method that was using it so i just fixed it right now so i
don't have to rewrite the unit-test later
bq. On 2012-04-04 18:34:56, Chris Mattmann wrote:
bq. > trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/OutputDir.java,
line 49
bq. > <https://reviews.apache.org/r/4628/diff/1/?file=98792#file98792line49>
bq. >
bq. > +like
ack
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4628/#review6686
-----------------------------------------------------------
On 2012-04-06 02:16:10, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4628/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-06 02:16:10)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and
Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CAS-PGE Changes to this issue...
bq. - Renaming and Metadata extraction removed from CAS-PGE and instead
CAS-PGE now uses AutoDetectProductCrawler instead of StdProductCrawler
bq.
bq.
bq. This addresses bug OODT-426.
bq. https://issues.apache.org/jira/browse/OODT-426
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/pge/src/main/resources/examples/Crawler/naming-beans.xml
PRE-CREATION
bq. trunk/pge/src/main/resources/examples/Crawler/precondition-beans.xml
PRE-CREATION
bq.
trunk/pge/src/main/resources/examples/MetadataOutputFiles/metadata-output.xml
1302648
bq. trunk/pge/src/main/resources/examples/PgeConfigFiles/pge-config.xml
1302648
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java
1302781
bq. trunk/pge/src/main/resources/examples/Crawler/mime-types.xml
PRE-CREATION
bq. trunk/pge/src/main/resources/examples/Crawler/mime-extractor-map.xml
PRE-CREATION
bq. trunk/pge/src/main/resources/examples/Crawler/crawler-config.xml
PRE-CREATION
bq.
trunk/pge/src/main/resources/examples/Crawler/filename.extractor.config.xml
PRE-CREATION
bq. trunk/pge/src/main/resources/examples/Crawler/action-beans.xml
PRE-CREATION
bq. trunk/pge/src/main/resources/examples/Crawler/action-beans.properties
PRE-CREATION
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/metlist/MetadataListPcsMetFileWriter.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/xslt/XslTransformWriter.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/SciPgeConfigFileWriter.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/ExternExtractorMetWriter.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/FilenameExtractorWriter.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/PcsMetFileWriter.java
1302648
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/RenamingConv.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigBuilder.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfigMetKeys.java
1302648
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/RegExprOutputFiles.java
1302648
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/OutputDir.java
1302648
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java
1302648
bq. trunk/pge/pom.xml 1302648
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
1302648
bq.
bq. Diff: https://reviews.apache.org/r/4628/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Several Unit-tests
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Introduce a CAS-Metadata based renaming interface
> -------------------------------------------------
>
> Key: OODT-426
> URL: https://issues.apache.org/jira/browse/OODT-426
> Project: OODT
> Issue Type: Sub-task
> Components: crawler, metadata container, pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.5
>
> Attachments: OODT-426.2012-03-20.cas-crawler.patch.txt,
> OODT-426.2012-03-20.cas-metadata.patch.txt,
> OODT-426.2012-03-24.cas-crawler.patch.txt, OODT-426.2012-04-03.cas-pge.txt
>
>
> The idea here is that CAS-Metadata will introduce a new NamingConvention
> interface, which will allow for renaming of files. CAS-Crawler will then be
> modified to support specified NamingConventions which will be run after all
> preconditions have passed for a given file. This will then allow CAS-PGE to
> then use AutoDetectProductCrawler instead of StdProductCrawler, which will
> standardize across the board for file extraction (currently CAS-PGE has it's
> own file extraction interface which uses regular expression to determine
> files which should be extracted and ingested). The only missing feature in
> CAS-Crawler which CAS-PGE supports is file renaming, which this new
> NamingConvention interface will introduce. Here is what the NamingConvention
> interface will look like:
> {code}
> public interface NamingConvention {
> public File rename(File file, Metadata metadata)
> throws NamingConventionException;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
