[
https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270988#comment-13270988
]
jirapos...@reviews.apache.org commented on OODT-310:
----------------------------------------------------
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. >
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java,
line 79
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq. >
bq. > When Success/done is passed in, the processor created is incorrect
since it has a sub-processor in Queued/waiting
bq.
bq. Chris Mattmann wrote:
bq. Thoughts on how to fix?
bq.
bq. Sheryl John wrote:
bq. If 'anydoneStates'/done is passed, then don't add taskProcessor and
return the 'done' processor?
bq.
bq. Chris Mattmann wrote:
bq. Good idea, Sheryl, I will try that.
bq.
bq. brian Foster wrote:
bq. Maybe change getProcessor signature to something along the lines of:
bq.
bq. private WorkflowProcessor getProcessor(String id,
bq. double priority,
bq. String stateName,
bq. String categoryName,
bq. List<WorkflowProcessor>
subProcessors);
bq.
bq. Then just make some helper methods which build test
WorkflowProcessors... Maybe even make a WorkflowProcessorBuilder class:
bq.
bq. public class WorkflowProcessorBuilder {
bq.
bq. private String id;
bq. private double priority;
bq. private List<WorkflowProcessor> subProcessors;
bq.
bq. private WorkflowProcessorBuilder() {
bq. subProcessors = Lists.newArrayList();
bq. }
bq.
bq. public static WorkflowProcessorBuilder aWorkflowProcessorBuilder() {
bq. return new WorkflowProcessorBuilder();
bq. }
bq.
bq. public WorkflowProcessorBuilder withId(String id) {
bq. this.id = id;
bq. return this;
bq. }
bq.
bq. public WorkflowProcessorBuilder withPriority(double priority) {
bq. this.priority = priority;
bq. return this;
bq. }
bq.
bq. public WorkflowProcessorBuilder with(WorkflowProcessorBuilder wpb) {
bq. subProcessors.add(wpb.build());
bq. return this;
bq. }
bq. ...
bq. ...
bq. ...
bq.
bq. public WorkflowProcessor build() {
bq. WorkflowProcessor wp = new ...
bq. wp.setId(id);
bq. wp.setPriority(priority);
bq. wp.setSubProcessors(subProcessors);
bq. ...
bq. return wp;
bq. }
bq. }
actually:
public static WorkflowProcessorBuilder aWorkflowProcessorBuilder() {
return new WorkflowProcessorBuilder();
}
should be:
public static WorkflowProcessorBuilder aWorkflowProcessor() {
return new WorkflowProcessorBuilder();
}
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl
John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on:
https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java
1332505
bq.
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java
1331866
bq.
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why
(something up with my threading logic and synchronized keywords) but wanted to
throw it up for review. I'll likely be working on this tomorrow or the
following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt,
> OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine
> interface and associated classes to trunk. This involves changing to the
> Processor model (Sequential, Condition, etc.) which has already begun (as of
> OODT-70), and also the actual Engine implementation itself, that doesn't
> block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
