[ 
https://issues.apache.org/jira/browse/OODT-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630057#comment-13630057
 ] 

Luca Cinquini commented on OODT-592:
------------------------------------

Hi Paul, great comments, all right on target. I commented on the review board 
too but to recap:

o +1 on renaming the core fields according to your last suggestion

o +1 on refactoring CompleteProduct to be a class used also by the Lucene 
catalog implementation, but I would suggest to do that AFTER the Lucene catalog 
implementation has been upgraded to the latest libraries

o Supporting the Solr client that comes with the solrj library is also a good 
idea. I would do that in addition to the current SolrClient that takes requests 
directly in XML/JSON format. 

o I thought about renaming the current SolrClient to FMSolrClient, but then on 
second thought it really has no dependency on the FileManager API, it could 
potentially be used by any application to communicate with a Solr server. So I 
would leave the name as it is unless you fell strongly about it.

thanks again, it's great to have such a thorough review.

Luca
                
> Native Solr implementation of CAS File manager
> ----------------------------------------------
>
>                 Key: OODT-592
>                 URL: https://issues.apache.org/jira/browse/OODT-592
>             Project: OODT
>          Issue Type: New Feature
>          Components: file manager
>    Affects Versions: 0.5
>            Reporter: Luca Cinquini
>            Assignee: Luca Cinquini
>             Fix For: 0.6
>
>
> Implement the CAS Catalog interface versus a standalone Solr server, so that 
> after products are ingested, their metadata can be query efficiently by 
> clients.
> See review board: https://reviews.apache.org/r/10288/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to