[ 
https://issues.apache.org/jira/browse/OODT-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744308#comment-13744308
 ] 

Rishi Verma commented on OODT-651:
----------------------------------

Hey Ross,

Great job. I reviewed your patch on Apache Reviews. Ship it!

Rishi
                
> Improve parameter initialization, validation and logging for the CAS-Product 
> JAXRS service
> ------------------------------------------------------------------------------------------
>
>                 Key: OODT-651
>                 URL: https://issues.apache.org/jira/browse/OODT-651
>             Project: OODT
>          Issue Type: Sub-task
>          Components: product server
>    Affects Versions: 0.7
>            Reporter: Ross Laidlaw
>            Assignee: Ross Laidlaw
>            Priority: Minor
>              Labels: gsoc
>             Fix For: 0.7
>
>         Attachments: OODT-651.rlaidlaw.2013-08-14.patch.txt
>
>
> My mentor Rishi Verma noted on OODT-649 that several components used by the 
> new CAS-Product JAX-RS service, such as the file manager client and working 
> directory, are being initialized in the resource classes for every HTTP 
> request.  This is inefficient and causes unnecessary overheads, since these 
> parameters (e.g. file manager URL and working directory location) are assumed 
> to be constant while the web application is running (i.e. if they do change, 
> the web application can be restarted to pick up the changes) and separate 
> file manager client instances aren't required for each request.
> Instead it would be better to initialize certain parameters only once when 
> the web application is started up and share them between the resource classes.
> Rishi also suggested that additional validation and logging would make the 
> application more robust and would help developers and users when configuring 
> the web application.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to