[ 
https://issues.apache.org/jira/browse/OODT-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808153#comment-13808153
 ] 

Luca Cinquini commented on OODT-656:
------------------------------------

If there are no objections, I would like to go ahead with this change.
Also, I would like to add the described functionality into a new servlet 
RestfulProductQueryServlet right in this package, so it can be leveraged by 
other projects, not just PDS. The servlet is coded to be completely generic. 
See review request at:

https://reviews.apache.org/r/15030/

> Change visibility of QueryServlet.getQuery() method
> ---------------------------------------------------
>
>                 Key: OODT-656
>                 URL: https://issues.apache.org/jira/browse/OODT-656
>             Project: OODT
>          Issue Type: Improvement
>          Components: grid
>    Affects Versions: 0.6
>            Reporter: Luca Cinquini
>            Assignee: Luca Cinquini
>             Fix For: 0.7
>
>
> The class QueryServlet uses the private method getQuery() to parse the HTTP 
> request and create an XMLQuery object to process.
> PDS has a need to provide its own parsing of the HTTP request parameters (in 
> order to enable an easier syntax than the current DIS-style query syntax). 
> This can be achieved by providing a subclass of QueryServlet that implements 
> its own version of getQuery().
> Therefore, it is suggested that we change the visibility of that method from 
> "private" to "protected". This change should have no ill effects on any of 
> the software using the QueryServlet class.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to