Repository: oozie Updated Branches: refs/heads/master f132c9ba4 -> dd053ebf0
OOZIE-2657 Clean up redundant access modifiers from oozie interfaces Project: http://git-wip-us.apache.org/repos/asf/oozie/repo Commit: http://git-wip-us.apache.org/repos/asf/oozie/commit/dd053ebf Tree: http://git-wip-us.apache.org/repos/asf/oozie/tree/dd053ebf Diff: http://git-wip-us.apache.org/repos/asf/oozie/diff/dd053ebf Branch: refs/heads/master Commit: dd053ebf061c2b68249dcfaaf291b8411f0e2459 Parents: f132c9b Author: jvishwakarma <jvishwaka...@walmartlabs.com> Authored: Sun Sep 18 22:36:19 2016 +0530 Committer: jvishwakarma <jvishwaka...@walmartlabs.com> Committed: Sun Sep 18 22:36:19 2016 +0530 ---------------------------------------------------------------------- .../org/apache/oozie/action/ActionExecutor.java | 20 ++++++------ .../input/dependency/CoordInputDependency.java | 34 ++++++++++---------- .../apache/oozie/workflow/lite/NodeHandler.java | 28 ++++++++-------- 3 files changed, 41 insertions(+), 41 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/oozie/blob/dd053ebf/core/src/main/java/org/apache/oozie/action/ActionExecutor.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/action/ActionExecutor.java b/core/src/main/java/org/apache/oozie/action/ActionExecutor.java index 3f978fd..1d6456b 100644 --- a/core/src/main/java/org/apache/oozie/action/ActionExecutor.java +++ b/core/src/main/java/org/apache/oozie/action/ActionExecutor.java @@ -94,28 +94,28 @@ public abstract class ActionExecutor { * @param externalStatusVar variable for the caller to inject the external status. * @return the callback URL. */ - public String getCallbackUrl(String externalStatusVar); + String getCallbackUrl(String externalStatusVar); /** * Return a proto configuration for actions with auth properties already set. * * @return a proto configuration for actions with auth properties already set. */ - public Configuration getProtoActionConf(); + Configuration getProtoActionConf(); /** * Return the workflow job. * * @return the workflow job. */ - public WorkflowJob getWorkflow(); + WorkflowJob getWorkflow(); /** * Return an ELEvaluator with the context injected. * * @return configured ELEvaluator. */ - public ELEvaluator getELEvaluator(); + ELEvaluator getELEvaluator(); /** * Set a workflow action variable. <p> Convenience method that prefixes the variable name with the action name @@ -124,7 +124,7 @@ public abstract class ActionExecutor { * @param name variable name. * @param value variable value, <code>null</code> removes the variable. */ - public void setVar(String name, String value); + void setVar(String name, String value); /** * Get a workflow action variable. <p> Convenience method that prefixes the variable name with the action name @@ -133,7 +133,7 @@ public abstract class ActionExecutor { * @param name variable name. * @return the variable value, <code>null</code> if not set. */ - public String getVar(String name); + String getVar(String name); /** * Set the action tracking information for an successfully started action. @@ -203,7 +203,7 @@ public abstract class ActionExecutor { * @return the path that will be used to store action specific data * @throws IOException @throws URISyntaxException @throws HadoopAccessorException */ - public Path getActionDir() throws HadoopAccessorException, IOException, URISyntaxException; + Path getActionDir() throws HadoopAccessorException, IOException, URISyntaxException; /** * @return filesystem handle for the application deployment fs. @@ -211,9 +211,9 @@ public abstract class ActionExecutor { * @throws URISyntaxException * @throws HadoopAccessorException */ - public FileSystem getAppFileSystem() throws HadoopAccessorException, IOException, URISyntaxException; + FileSystem getAppFileSystem() throws HadoopAccessorException, IOException, URISyntaxException; - public void setErrorInfo(String str, String exMsg); + void setErrorInfo(String str, String exMsg); } @@ -329,7 +329,7 @@ public abstract class ActionExecutor { /** * Register error handling information for an exception. * - * @param exClass excpetion class name (to work in case of a particular exception not being in the classpath, needed + * @param exClass exception class name (to work in case of a particular exception not being in the classpath, needed * to be able to handle multiple version of Hadoop or other JARs used by executors with the same codebase). * @param errorType error type for the exception. * @param errorCode error code for the exception. http://git-wip-us.apache.org/repos/asf/oozie/blob/dd053ebf/core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java b/core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java index cf0edd0..504bc3d 100644 --- a/core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java +++ b/core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java @@ -30,7 +30,7 @@ import org.jdom.JDOMException; public interface CoordInputDependency { - public static final String INTERNAL_VERSION_ID = "V=1"; + String INTERNAL_VERSION_ID = "V=1"; /** * Adds the input instance list. @@ -38,35 +38,35 @@ public interface CoordInputDependency { * @param inputEventName the input event name * @param inputInstanceList the input instance list */ - public void addInputInstanceList(String inputEventName, List<CoordInputInstance> inputInstanceList); + void addInputInstanceList(String inputEventName, List<CoordInputInstance> inputInstanceList); /** * Gets the missing dependencies. * * @return the missing dependencies */ - public String getMissingDependencies(); + String getMissingDependencies(); /** * Checks if dependencies are meet. * * @return true, if dependencies are meet */ - public boolean isDependencyMet(); + boolean isDependencyMet(); /** * Checks if is unresolved dependencies met. * * @return true, if unresolved dependencies are met */ - public boolean isUnResolvedDependencyMet(); + boolean isUnResolvedDependencyMet(); /** * Sets the dependency meet. * * @param isMissingDependenciesMet the new dependency met */ - public void setDependencyMet(boolean isMissingDependenciesMet); + void setDependencyMet(boolean isMissingDependenciesMet); /** * Serialize. @@ -74,28 +74,28 @@ public interface CoordInputDependency { * @return the string * @throws IOException Signals that an I/O exception has occurred. */ - public String serialize() throws IOException; + String serialize() throws IOException; /** * Gets the missing dependencies as list. * * @return the missing dependencies as list */ - public List<String> getMissingDependenciesAsList(); + List<String> getMissingDependenciesAsList(); /** * Gets the available dependencies as list. * * @return the available dependencies as list */ - public List<String> getAvailableDependenciesAsList(); + List<String> getAvailableDependenciesAsList(); /** * Sets the missing dependencies. * * @param missingDependencies the new missing dependencies */ - public void setMissingDependencies(String missingDependencies); + void setMissingDependencies(String missingDependencies); /** * Adds the un resolved list. @@ -103,7 +103,7 @@ public interface CoordInputDependency { * @param name the name * @param tmpUnresolved the tmp unresolved */ - public void addUnResolvedList(String name, String tmpUnresolved); + void addUnResolvedList(String name, String tmpUnresolved); /** * Gets the available dependencies. @@ -111,14 +111,14 @@ public interface CoordInputDependency { * @param dataSet the data set * @return the available dependencies */ - public List<String> getAvailableDependencies(String dataSet); + List<String> getAvailableDependencies(String dataSet); /** * Adds the to available dependencies. * * @param availDepList the avail dep list */ - public void addToAvailableDependencies(Collection<String> availDepList); + void addToAvailableDependencies(Collection<String> availDepList); /** * Check push missing dependencies. @@ -130,7 +130,7 @@ public interface CoordInputDependency { * @throws IOException Signals that an I/O exception has occurred. * @throws JDOMException the JDOM exception */ - public ActionDependency checkPushMissingDependencies(CoordinatorActionBean coordAction, + ActionDependency checkPushMissingDependencies(CoordinatorActionBean coordAction, boolean registerForNotification) throws CommandException, IOException, JDOMException; /** @@ -143,7 +143,7 @@ public interface CoordInputDependency { * @throws IOException Signals that an I/O exception has occurred. * @throws JDOMException the JDOM exception */ - public boolean checkPullMissingDependencies(CoordinatorActionBean coordAction, StringBuilder existList, + boolean checkPullMissingDependencies(CoordinatorActionBean coordAction, StringBuilder existList, StringBuilder nonExistList) throws IOException, JDOMException; /** @@ -155,7 +155,7 @@ public interface CoordInputDependency { * @param status the status * @return true, if is change in dependency */ - public boolean isChangeInDependency(StringBuilder nonExistList, String missingDependencies, + boolean isChangeInDependency(StringBuilder nonExistList, String missingDependencies, StringBuilder nonResolvedList, boolean status); /** @@ -166,7 +166,7 @@ public interface CoordInputDependency { * @return true, if successful * @throws Exception the exception */ - public boolean checkUnresolved(CoordinatorActionBean coordAction, Element eAction) + boolean checkUnresolved(CoordinatorActionBean coordAction, Element eAction) throws Exception; } http://git-wip-us.apache.org/repos/asf/oozie/blob/dd053ebf/core/src/main/java/org/apache/oozie/workflow/lite/NodeHandler.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/workflow/lite/NodeHandler.java b/core/src/main/java/org/apache/oozie/workflow/lite/NodeHandler.java index 89a53fe..3def0d5 100644 --- a/core/src/main/java/org/apache/oozie/workflow/lite/NodeHandler.java +++ b/core/src/main/java/org/apache/oozie/workflow/lite/NodeHandler.java @@ -30,36 +30,36 @@ public abstract class NodeHandler { public interface Context { - public NodeDef getNodeDef(); + NodeDef getNodeDef(); - public String getExecutionPath(); + String getExecutionPath(); - public String getParentExecutionPath(String executionPath); + String getParentExecutionPath(String executionPath); - public String getSignalValue(); + String getSignalValue(); - public void setVar(String name, String value); + void setVar(String name, String value); - public String getVar(String name); + String getVar(String name); - public void setTransientVar(String name, Object value); + void setTransientVar(String name, Object value); - public Object getTransientVar(String name); + Object getTransientVar(String name); - public String createExecutionPath(String name); + String createExecutionPath(String name); //can be called only from exit(), creation of execPaths is automatic //when a handler returns more than one transition. - public void deleteExecutionPath(); + void deleteExecutionPath(); //must be used by multiExit - public String createFullTransition(String executionPath, String transition); + String createFullTransition(String executionPath, String transition); - public void killJob(); + void killJob(); - public void completeJob(); + void completeJob(); - public LiteWorkflowInstance getProcessInstance(); + LiteWorkflowInstance getProcessInstance(); } private static final String VISITED = "visited";