Repository: oozie Updated Branches: refs/heads/master 5983cdfe3 -> 061195621
OOZIE-2935 Fix "concatenates strings using + in a loop" Findbugs error in oozie-sharelib-streaming (Jan Hentschel via rkanter) Project: http://git-wip-us.apache.org/repos/asf/oozie/repo Commit: http://git-wip-us.apache.org/repos/asf/oozie/commit/06119562 Tree: http://git-wip-us.apache.org/repos/asf/oozie/tree/06119562 Diff: http://git-wip-us.apache.org/repos/asf/oozie/diff/06119562 Branch: refs/heads/master Commit: 06119562194fdac8e6c7a81ca9139b8feb851af0 Parents: 5983cdf Author: Robert Kanter <rkan...@apache.org> Authored: Tue Jun 13 17:42:40 2017 -0700 Committer: Robert Kanter <rkan...@apache.org> Committed: Tue Jun 13 17:42:40 2017 -0700 ---------------------------------------------------------------------- release-log.txt | 1 + .../org/apache/oozie/action/hadoop/StreamingMain.java | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/oozie/blob/06119562/release-log.txt ---------------------------------------------------------------------- diff --git a/release-log.txt b/release-log.txt index 794d46c..ab40faa 100644 --- a/release-log.txt +++ b/release-log.txt @@ -1,5 +1,6 @@ -- Oozie 5.0.0 release (trunk - unreleased) +OOZIE-2935 Fix "concatenates strings using + in a loop" Findbugs error in oozie-sharelib-streaming (Jan Hentschel via rkanter) OOZIE-2825 Custom Authentication doc page is not well formatted (Jan Hentschel via rkanter) OOZIE-2747 README.txt is out of date (Jan Hentschel via rkanter) OOZIE-2926 Update Oozie version to 5.0.0-SNAPSHOT (dbist13 via rkanter) http://git-wip-us.apache.org/repos/asf/oozie/blob/06119562/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java ---------------------------------------------------------------------- diff --git a/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java b/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java index cc55166..4afb787 100644 --- a/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java +++ b/sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java @@ -66,10 +66,16 @@ public class StreamingMain extends MapReduceMain { if (value.length() > 0) { value = value + " "; } + + StringBuilder buffer = new StringBuilder(); + buffer.append(value); + for (String s : values) { - value = value + s + " "; + buffer.append(s); + buffer.append(" "); } - jobConf.set("stream.addenvironment", value); + + jobConf.set("stream.addenvironment", buffer.toString()); super.addActionConf(jobConf, actionConf); }
