OOZIE-2097 Get rid of non-Javadoc comments (Jan Hentschel via andras.piros)
Project: http://git-wip-us.apache.org/repos/asf/oozie/repo Commit: http://git-wip-us.apache.org/repos/asf/oozie/commit/b0f0dc1d Tree: http://git-wip-us.apache.org/repos/asf/oozie/tree/b0f0dc1d Diff: http://git-wip-us.apache.org/repos/asf/oozie/diff/b0f0dc1d Branch: refs/heads/master Commit: b0f0dc1d548837903ce280c3a2e6d57e21d9013d Parents: 6ef938c Author: Andras Piros <andras.pi...@cloudera.com> Authored: Fri Jun 1 15:39:09 2018 +0200 Committer: Andras Piros <andras.pi...@cloudera.com> Committed: Fri Jun 1 15:39:09 2018 +0200 ---------------------------------------------------------------------- .../java/org/apache/oozie/BundleEngine.java | 42 -------------- .../org/apache/oozie/CoordinatorEngine.java | 61 -------------------- .../org/apache/oozie/CoordinatorJobBean.java | 15 ----- .../main/java/org/apache/oozie/DagEngine.java | 6 -- .../oozie/action/hadoop/HCatCredentials.java | 4 -- .../oozie/action/hadoop/HbaseCredentials.java | 4 -- .../oozie/client/rest/BulkResponseImpl.java | 9 --- .../apache/oozie/command/BulkJobsXCommand.java | 15 ----- .../oozie/command/KillTransitionXCommand.java | 6 -- .../command/MaterializeTransitionXCommand.java | 6 -- .../oozie/command/PauseTransitionXCommand.java | 6 -- .../org/apache/oozie/command/PurgeXCommand.java | 15 ----- .../oozie/command/RerunTransitionXCommand.java | 15 ----- .../oozie/command/ResumeTransitionXCommand.java | 3 - .../oozie/command/StartTransitionXCommand.java | 6 -- .../oozie/command/SubmitTransitionXCommand.java | 6 -- .../command/SuspendTransitionXCommand.java | 3 - .../oozie/command/TransitionXCommand.java | 3 - .../command/UnpauseTransitionXCommand.java | 6 -- .../command/bundle/BulkBundleXCommand.java | 15 ----- .../command/bundle/BundleJobChangeXCommand.java | 9 --- .../command/bundle/BundleJobResumeXCommand.java | 27 --------- .../bundle/BundleJobSuspendXCommand.java | 27 --------- .../oozie/command/bundle/BundleJobXCommand.java | 15 ----- .../command/bundle/BundleJobsXCommand.java | 15 ----- .../command/bundle/BundlePauseXCommand.java | 21 ------- .../command/bundle/BundleRerunXCommand.java | 28 --------- .../command/bundle/BundleStartXCommand.java | 21 ------- .../command/bundle/BundleSubmitXCommand.java | 18 ------ .../command/bundle/BundleUnpauseXCommand.java | 35 ----------- .../oozie/command/coord/BulkCoordXCommand.java | 15 ----- .../command/coord/CoordActionCheckXCommand.java | 15 ----- .../command/coord/CoordActionInfoXCommand.java | 15 ----- .../coord/CoordActionTimeOutXCommand.java | 15 ----- .../coord/CoordActionUpdateXCommand.java | 6 -- .../command/coord/CoordActionsKillXCommand.java | 5 -- .../command/coord/CoordChangeXCommand.java | 15 ----- .../oozie/command/coord/CoordJobXCommand.java | 15 ----- .../oozie/command/coord/CoordJobsXCommand.java | 15 ----- .../CoordMaterializeTransitionXCommand.java | 27 --------- .../oozie/command/coord/CoordPauseXCommand.java | 21 ------- .../oozie/command/coord/CoordRerunXCommand.java | 22 ------- .../command/coord/CoordSubmitXCommand.java | 24 -------- .../command/coord/CoordUnpauseXCommand.java | 35 ----------- .../coord/CoordWfActionInfoXCommand.java | 18 ------ .../oozie/command/wf/ActionStartXCommand.java | 3 - .../apache/oozie/command/wf/ActionXCommand.java | 58 ------------------- .../oozie/command/wf/BulkWorkflowXCommand.java | 15 ----- .../command/wf/CompletedActionXCommand.java | 35 ----------- .../apache/oozie/command/wf/JobXCommand.java | 15 ----- .../apache/oozie/command/wf/JobsXCommand.java | 15 ----- .../apache/oozie/command/wf/ReRunXCommand.java | 15 ----- .../oozie/command/wf/SubmitHttpXCommand.java | 3 - .../command/wf/WorkflowActionInfoXCommand.java | 9 --- .../jpa/BundleActionGetJPAExecutor.java | 6 -- .../jpa/BundleActionInsertJPAExecutor.java | 6 -- .../BundleJobGetCoordinatorsJPAExecutor.java | 6 -- .../jpa/BundleJobGetForUserJPAExecutor.java | 11 ---- .../executor/jpa/BundleJobGetJPAExecutor.java | 6 -- .../jpa/BundleJobInfoGetJPAExecutor.java | 6 -- .../jpa/BundleJobInsertJPAExecutor.java | 6 -- .../jpa/BundleJobsDeleteJPAExecutor.java | 11 ---- .../jpa/BundleJobsGetForPurgeJPAExecutor.java | 6 -- ...undleJobsGetRunningOrPendingJPAExecutor.java | 6 -- .../jpa/CoordActionGetForCheckJPAExecutor.java | 6 -- .../CoordActionGetForExternalIdJPAExecutor.java | 6 -- .../jpa/CoordActionGetForInfoJPAExecutor.java | 6 -- .../CoordActionGetForInputCheckJPAExecutor.java | 6 -- .../jpa/CoordActionGetForStartJPAExecutor.java | 6 -- .../CoordActionGetForTimeoutJPAExecutor.java | 6 -- .../executor/jpa/CoordActionGetJPAExecutor.java | 6 -- .../jpa/CoordActionInsertJPAExecutor.java | 6 -- .../jpa/CoordActionRemoveJPAExecutor.java | 6 -- .../jpa/CoordActionsDeleteJPAExecutor.java | 11 ---- .../jpa/CoordActionsRunningGetJPAExecutor.java | 6 -- ...rdJobGetActionByActionNumberJPAExecutor.java | 6 -- .../executor/jpa/CoordJobGetJPAExecutor.java | 6 -- .../executor/jpa/CoordJobInsertJPAExecutor.java | 6 -- ...CountNotForPurgeFromParentIdJPAExecutor.java | 6 -- .../jpa/CoordJobsDeleteJPAExecutor.java | 11 ---- .../CoordJobsGetFromParentIdJPAExecutor.java | 6 -- .../jpa/CoordJobsGetPendingJPAExecutor.java | 6 -- .../CoordJobsToBeMaterializedJPAExecutor.java | 3 - ...rdinatorJobGetForUserAppnameJPAExecutor.java | 11 ---- .../CoordinatorJobGetForUserJPAExecutor.java | 11 ---- .../executor/jpa/SLAEventInsertJPAExecutor.java | 6 -- .../jpa/WorkflowActionDeleteJPAExecutor.java | 6 -- .../jpa/WorkflowActionGetJPAExecutor.java | 6 -- .../jpa/WorkflowActionInsertJPAExecutor.java | 6 -- ...WorkflowActionRetryManualGetJPAExecutor.java | 6 -- .../jpa/WorkflowActionSubsetGetJPAExecutor.java | 6 -- .../WorkflowActionsGetForJobJPAExecutor.java | 6 -- .../WorkflowIdGetForExternalIdJPAExecutor.java | 6 -- ...flowInfoWithActionsSubsetGetJPAExecutor.java | 6 -- .../jpa/WorkflowJobDeleteJPAExecutor.java | 6 -- .../jpa/WorkflowJobGetForUserJPAExecutor.java | 11 ---- .../executor/jpa/WorkflowJobGetJPAExecutor.java | 6 -- .../jpa/WorkflowJobInsertJPAExecutor.java | 6 -- .../jpa/WorkflowJobsDeleteJPAExecutor.java | 11 ---- .../jpa/WorkflowJobsGetForPurgeJPAExecutor.java | 6 -- .../jpa/WorkflowsJobGetJPAExecutor.java | 6 -- .../org/apache/oozie/jms/MessageReceiver.java | 5 -- .../oozie/service/CallableQueueService.java | 5 -- .../apache/oozie/servlet/V0AdminServlet.java | 22 ------- .../apache/oozie/servlet/V1AdminServlet.java | 15 ----- .../org/apache/oozie/workflow/lite/NodeDef.java | 6 -- .../oozie/action/hadoop/InsertTestToken.java | 5 -- .../command/wf/TestActionStartXCommand.java | 5 -- .../TestBundleJobsGetForPurgeJPAExecutor.java | 6 -- .../TestCoordJobsGetForPurgeJPAExecutor.java | 6 -- ...estCoordJobsToBeMaterializedJPAExecutor.java | 6 -- release-log.txt | 1 + 112 files changed, 1 insertion(+), 1293 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/BundleEngine.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/BundleEngine.java b/core/src/main/java/org/apache/oozie/BundleEngine.java index 5c70b2e..19b54e6 100644 --- a/core/src/main/java/org/apache/oozie/BundleEngine.java +++ b/core/src/main/java/org/apache/oozie/BundleEngine.java @@ -81,9 +81,6 @@ public class BundleEngine extends BaseEngine { this.user = ParamChecker.notEmpty(user, "user"); } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#change(java.lang.String, java.lang.String) - */ @Override public void change(String jobId, String changeValue) throws BundleEngineException { try { @@ -95,9 +92,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#dryRunSubmit(org.apache.hadoop.conf.Configuration) - */ @Override public String dryRunSubmit(Configuration conf) throws BundleEngineException { BundleSubmitXCommand submit = new BundleSubmitXCommand(true, conf); @@ -110,9 +104,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#getCoordJob(java.lang.String) - */ @Override public CoordinatorJob getCoordJob(String jobId) throws BundleEngineException { throw new BundleEngineException(new XException(ErrorCode.E0301, "cannot get a coordinator job from BundleEngine")); @@ -127,9 +118,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#getCoordJob(java.lang.String, int, int) - */ @Override public CoordinatorJob getCoordJob(String jobId, String filter, int start, int length, boolean desc) throws BundleEngineException { @@ -137,9 +125,6 @@ public class BundleEngine extends BaseEngine { "cannot get a coordinator job from BundleEngine")); } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#getDefinition(java.lang.String) - */ @Override public String getDefinition(String jobId) throws BundleEngineException { BundleJobBean job; @@ -152,33 +137,21 @@ public class BundleEngine extends BaseEngine { return job.getOrigJobXml(); } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#getJob(java.lang.String) - */ @Override public WorkflowJob getJob(String jobId) throws BundleEngineException { throw new BundleEngineException(new XException(ErrorCode.E0301, "cannot get a workflow job from BundleEngine")); } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#getJob(java.lang.String, int, int) - */ @Override public WorkflowJob getJob(String jobId, int start, int length) throws BundleEngineException { throw new BundleEngineException(new XException(ErrorCode.E0301, "cannot get a workflow job from BundleEngine")); } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#getJobIdForExternalId(java.lang.String) - */ @Override public String getJobIdForExternalId(String externalId) throws BundleEngineException { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#kill(java.lang.String) - */ @Override public void kill(String jobId) throws BundleEngineException { try { @@ -189,9 +162,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#reRun(java.lang.String, org.apache.hadoop.conf.Configuration) - */ @Override @Deprecated public void reRun(String jobId, Configuration conf) throws BundleEngineException { @@ -218,9 +188,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#resume(java.lang.String) - */ @Override public void resume(String jobId) throws BundleEngineException { BundleJobResumeXCommand resume = new BundleJobResumeXCommand(jobId); @@ -232,9 +199,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#start(java.lang.String) - */ @Override public void start(String jobId) throws BundleEngineException { try { @@ -266,9 +230,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#submitJob(org.apache.hadoop.conf.Configuration, boolean) - */ @Override public String submitJob(Configuration conf, boolean startJob) throws BundleEngineException { try { @@ -284,9 +245,6 @@ public class BundleEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#suspend(java.lang.String) - */ @Override public void suspend(String jobId) throws BundleEngineException { BundleJobSuspendXCommand suspend = new BundleJobSuspendXCommand(jobId); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/CoordinatorEngine.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/CoordinatorEngine.java b/core/src/main/java/org/apache/oozie/CoordinatorEngine.java index 0a4703e..0aa56d1 100644 --- a/core/src/main/java/org/apache/oozie/CoordinatorEngine.java +++ b/core/src/main/java/org/apache/oozie/CoordinatorEngine.java @@ -124,11 +124,6 @@ public class CoordinatorEngine extends BaseEngine { this.user = ParamChecker.notEmpty(user, "user"); } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#getDefinition(java.lang.String) - */ @Override public String getDefinition(String jobId) throws BaseEngineException { CoordinatorJobBean job = getCoordJobWithNoActionInfo(jobId); @@ -163,11 +158,6 @@ public class CoordinatorEngine extends BaseEngine { } } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#getCoordJob(java.lang.String) - */ @Override public CoordinatorJobBean getCoordJob(String jobId) throws BaseEngineException { try { @@ -178,11 +168,6 @@ public class CoordinatorEngine extends BaseEngine { } } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#getCoordJob(java.lang.String, java.lang.String, int, int) - */ @Override public CoordinatorJobBean getCoordJob(String jobId, String filter, int offset, int length, boolean desc) throws BaseEngineException { @@ -195,21 +180,11 @@ public class CoordinatorEngine extends BaseEngine { } } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#getJobIdForExternalId(java.lang.String) - */ @Override public String getJobIdForExternalId(String externalId) throws CoordinatorEngineException { return null; } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#kill(java.lang.String) - */ @Override public void kill(String jobId) throws CoordinatorEngineException { try { @@ -230,9 +205,6 @@ public class CoordinatorEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#change(java.lang.String, java.lang.String) - */ @Override public void change(String jobId, String changeValue) throws CoordinatorEngineException { try { @@ -286,11 +258,6 @@ public class CoordinatorEngine extends BaseEngine { } } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#resume(java.lang.String) - */ @Override public void resume(String jobId) throws CoordinatorEngineException { try { @@ -500,13 +467,6 @@ public class CoordinatorEngine extends BaseEngine { endTime, writer); } - /* - * (non-Javadoc) - * - * @see - * org.apache.oozie.BaseEngine#submitJob(org.apache.hadoop.conf.Configuration - * , boolean) - */ @Override public String submitJob(Configuration conf, boolean startJob) throws CoordinatorEngineException { try { @@ -518,12 +478,6 @@ public class CoordinatorEngine extends BaseEngine { } } - /* - * (non-Javadoc) - * - * @see - * org.apache.oozie.BaseEngine#dryRunSubmit(org.apache.hadoop.conf.Configuration) - */ @Override public String dryRunSubmit(Configuration conf) throws CoordinatorEngineException { try { @@ -535,11 +489,6 @@ public class CoordinatorEngine extends BaseEngine { } } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#suspend(java.lang.String) - */ @Override public void suspend(String jobId) throws CoordinatorEngineException { try { @@ -551,21 +500,11 @@ public class CoordinatorEngine extends BaseEngine { } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#getJob(java.lang.String) - */ @Override public WorkflowJob getJob(String jobId) throws BaseEngineException { throw new BaseEngineException(new XException(ErrorCode.E0301, "cannot get a workflow job from CoordinatorEngine")); } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.BaseEngine#getJob(java.lang.String, int, int) - */ @Override public WorkflowJob getJob(String jobId, int start, int length) throws BaseEngineException { throw new BaseEngineException(new XException(ErrorCode.E0301, "cannot get a workflow job from CoordinatorEngine")); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java index 1fe3c63..2a936d6 100644 --- a/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java +++ b/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java @@ -794,9 +794,6 @@ public class CoordinatorJobBean implements Writable, CoordinatorJob, JsonBean { this.timeUnitStr = timeUnit.toString(); } - /* (non-Javadoc) - * @see org.apache.oozie.client.rest.JsonCoordinatorJob#getTimeUnit() - */ @Override public Timeunit getTimeUnit() { return Timeunit.valueOf(this.timeUnitStr); @@ -811,9 +808,6 @@ public class CoordinatorJobBean implements Writable, CoordinatorJob, JsonBean { this.execution = order.toString(); } - /* (non-Javadoc) - * @see org.apache.oozie.client.rest.JsonCoordinatorJob#getExecutionOrder() - */ @Override public Execution getExecutionOrder() { return Execution.valueOf(this.execution); @@ -840,9 +834,6 @@ public class CoordinatorJobBean implements Writable, CoordinatorJob, JsonBean { this.lastActionTimestamp = DateUtils.convertDateToTimestamp(lastAction); } - /* (non-Javadoc) - * @see org.apache.oozie.client.rest.JsonCoordinatorJob#getLastActionTime() - */ @Override public Date getLastActionTime() { return DateUtils.toDate(lastActionTimestamp); @@ -861,9 +852,6 @@ public class CoordinatorJobBean implements Writable, CoordinatorJob, JsonBean { this.nextMaterializedTimestamp = DateUtils.convertDateToTimestamp(nextMaterializedTime); } - /* (non-Javadoc) - * @see org.apache.oozie.client.rest.JsonCoordinatorJob#getNextMaterializedTime() - */ @Override public Date getNextMaterializedTime() { return DateUtils.toDate(nextMaterializedTimestamp); @@ -909,9 +897,6 @@ public class CoordinatorJobBean implements Writable, CoordinatorJob, JsonBean { this.startTimestamp = DateUtils.convertDateToTimestamp(startTime); } - /* (non-Javadoc) - * @see org.apache.oozie.client.rest.JsonCoordinatorJob#getStartTime() - */ @Override public Date getStartTime() { return DateUtils.toDate(startTimestamp); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/DagEngine.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/DagEngine.java b/core/src/main/java/org/apache/oozie/DagEngine.java index bb166d4..70ce961 100644 --- a/core/src/main/java/org/apache/oozie/DagEngine.java +++ b/core/src/main/java/org/apache/oozie/DagEngine.java @@ -264,9 +264,6 @@ public class DagEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#change(java.lang.String, java.lang.String) - */ @Override public void change(String jobId, String changeValue) throws DagEngineException { // This code should not be reached. @@ -535,9 +532,6 @@ public class DagEngine extends BaseEngine { } } - /* (non-Javadoc) - * @see org.apache.oozie.BaseEngine#dryRunSubmit(org.apache.hadoop.conf.Configuration) - */ @Override public String dryRunSubmit(Configuration conf) throws BaseEngineException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java b/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java index 9260d83..5f11b9f 100644 --- a/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java +++ b/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java @@ -48,10 +48,6 @@ public class HCatCredentials implements CredentialsProvider { hiveConf.addResource("hive-site.xml"); } - /* (non-Javadoc) - * @see org.apache.oozie.action.hadoop.Credentials#addtoJobConf(org.apache.hadoop.mapred.JobConf, - * org.apache.oozie.action.hadoop.CredentialsProperties, org.apache.oozie.action.ActionExecutor.Context) - */ @Override public void updateCredentials(Credentials credentials, Configuration config, CredentialsProperties props, Context context) throws Exception { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java b/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java index 8fc03b8..1c1d8a3 100644 --- a/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java +++ b/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java @@ -51,10 +51,6 @@ public class HbaseCredentials implements CredentialsProvider { Configuration.addDefaultResource(OOZIE_HBASE_CLIENT_SITE_XML); } - /* (non-Javadoc) - * @see org.apache.oozie.action.hadoop.Credentials#addtoJobConf(org.apache.hadoop.mapred.JobConf, - * org.apache.oozie.action.hadoop.CredentialsProperties, org.apache.oozie.action.ActionExecutor.Context) - */ @Override public void updateCredentials(Credentials credentials, Configuration config, CredentialsProperties props, Context context) throws Exception { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java b/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java index 8f3b09f..304d723 100644 --- a/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java +++ b/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java @@ -79,25 +79,16 @@ public class BulkResponseImpl implements BulkResponse, JsonBean { return json; } - /* (non-Javadoc) - * @see org.apache.oozie.client.BulkResponse#getBundle() - */ @Override public BundleJobBean getBundle() { return bundle; } - /* (non-Javadoc) - * @see org.apache.oozie.client.BulkResponse#getCoordinator() - */ @Override public CoordinatorJobBean getCoordinator() { return coordinator; } - /* (non-Javadoc) - * @see org.apache.oozie.client.BulkResponse#getAction() - */ @Override public CoordinatorActionBean getAction() { return action; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java b/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java index 94a4f3a..587dbf9 100644 --- a/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java @@ -53,39 +53,24 @@ public class BulkJobsXCommand extends XCommand<BulkResponseInfo> { this.len = length; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected BulkResponseInfo execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java index 44fec54..1fefabd 100644 --- a/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/KillTransitionXCommand.java @@ -32,9 +32,6 @@ public abstract class KillTransitionXCommand<T> extends TransitionXCommand<T> { public abstract void killChildren() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public void transitToNext() { if (job == null) { @@ -44,9 +41,6 @@ public abstract class KillTransitionXCommand<T> extends TransitionXCommand<T> { job.setPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#execute() - */ @Override protected T execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java index bf1221d..d8c406e 100644 --- a/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/MaterializeTransitionXCommand.java @@ -51,9 +51,6 @@ public abstract class MaterializeTransitionXCommand extends TransitionXCommand<V super(name, type, priority, dryrun); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public void transitToNext() throws CommandException { } @@ -64,9 +61,6 @@ public abstract class MaterializeTransitionXCommand extends TransitionXCommand<V */ protected abstract void materialize() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#execute() - */ @Override protected Void execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/PauseTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/PauseTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/PauseTransitionXCommand.java index c2d9f83..f4272f3 100644 --- a/core/src/main/java/org/apache/oozie/command/PauseTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/PauseTransitionXCommand.java @@ -47,9 +47,6 @@ public abstract class PauseTransitionXCommand extends TransitionXCommand<Void> { */ public abstract void pauseChildren() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public final void transitToNext() throws CommandException { if (job == null) { @@ -73,9 +70,6 @@ public abstract class PauseTransitionXCommand extends TransitionXCommand<Void> { //job.setPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#execute() - */ @Override protected Void execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java b/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java index 166c236..42c3b28 100644 --- a/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java @@ -89,9 +89,6 @@ public class PurgeXCommand extends XCommand<Void> { bundleDel = 0; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { try { @@ -138,9 +135,6 @@ public class PurgeXCommand extends XCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { LOG.info("STARTED Purge to purge Workflow Jobs older than [{0}] days, Coordinator Jobs older than [{1}] days, and Bundle" @@ -412,25 +406,16 @@ public class PurgeXCommand extends XCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return "purge_command"; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java index 94bafa5..d3d389e 100644 --- a/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java @@ -59,9 +59,6 @@ public abstract class RerunTransitionXCommand<T> extends TransitionXCommand<T> { super(name, type, priority, dryrun); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public void transitToNext() { if (job == null) { @@ -86,9 +83,6 @@ public abstract class RerunTransitionXCommand<T> extends TransitionXCommand<T> { */ public abstract void rerunChildren() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#execute() - */ @Override protected T execute() throws CommandException { getLog().info("STARTED " + getClass().getSimpleName() + " for jobId=" + jobId); @@ -105,25 +99,16 @@ public abstract class RerunTransitionXCommand<T> extends TransitionXCommand<T> { return ret; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { eagerVerifyPrecondition(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#eagerLoadState() - */ @Override protected void eagerLoadState() throws CommandException { loadState(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#eagerVerifyPrecondition() - */ @Override protected void eagerVerifyPrecondition() throws CommandException, PreconditionException { if (getJob().getStatus() == Job.Status.KILLED || getJob().getStatus() == Job.Status.FAILED http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java index 0e40dc1..61244cc 100644 --- a/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java @@ -59,9 +59,6 @@ public abstract class ResumeTransitionXCommand extends TransitionXCommand<Void> job.setPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { transitToNext(); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java index 9f85e1f..ccc683f 100644 --- a/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/StartTransitionXCommand.java @@ -60,9 +60,6 @@ public abstract class StartTransitionXCommand extends TransitionXCommand<Void> { */ public abstract void StartChildren() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public final void transitToNext() { if (job == null) { @@ -72,9 +69,6 @@ public abstract class StartTransitionXCommand extends TransitionXCommand<Void> { job.setPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#execute() - */ @Override protected Void execute() throws CommandException { transitToNext(); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java index 9a4e586..6cb5cba 100644 --- a/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java @@ -60,9 +60,6 @@ public abstract class SubmitTransitionXCommand extends TransitionXCommand<String */ protected abstract String submit() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public void transitToNext() { if (job == null) { @@ -72,9 +69,6 @@ public abstract class SubmitTransitionXCommand extends TransitionXCommand<String job.resetPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected String execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java index d64e55f..6b3a2e5 100644 --- a/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java @@ -65,9 +65,6 @@ public abstract class SuspendTransitionXCommand extends TransitionXCommand<Void> job.setPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { transitToNext(); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java index 6024138..0c10103 100644 --- a/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java @@ -97,9 +97,6 @@ public abstract class TransitionXCommand<T> extends XCommand<T> { */ public abstract void performWrites() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected T execute() throws CommandException { transitToNext(); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/UnpauseTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/UnpauseTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/UnpauseTransitionXCommand.java index 1dfd3b5..0c9ba18 100644 --- a/core/src/main/java/org/apache/oozie/command/UnpauseTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/UnpauseTransitionXCommand.java @@ -47,9 +47,6 @@ public abstract class UnpauseTransitionXCommand extends TransitionXCommand<Void> */ public abstract void unpauseChildren() throws CommandException; - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#transitToNext() - */ @Override public final void transitToNext() throws CommandException { if (job == null) { @@ -73,9 +70,6 @@ public abstract class UnpauseTransitionXCommand extends TransitionXCommand<Void> //job.setPending(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#execute() - */ @Override protected Void execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java index d405ccb..dbe70ae 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java @@ -55,40 +55,25 @@ public class BulkBundleXCommand extends XCommand<BundleJobInfo> { this.operation = operation; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { loadBundleJobs(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected BundleJobInfo execute() throws CommandException { List<BundleJobBean> jobs = this.bundleJobInfo.getBundleJobs(); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java index 5c9251a..8628ea4 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java @@ -158,9 +158,6 @@ public class BundleJobChangeXCommand extends XCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { StringBuffer changeReport = new StringBuffer(); @@ -210,17 +207,11 @@ public class BundleJobChangeXCommand extends XCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return this.jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java index e2bd69f..bc58be6 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java @@ -59,9 +59,6 @@ public class BundleJobResumeXCommand extends ResumeTransitionXCommand { this.bundleId = ParamChecker.notNull(jobId, "BundleId"); } - /* (non-Javadoc) - * @see org.apache.oozie.command.ResumeTransitionXCommand#resumeChildren() - */ @Override public void resumeChildren() { for (BundleActionBean action : bundleActions) { @@ -104,17 +101,11 @@ public class BundleJobResumeXCommand extends ResumeTransitionXCommand { BundleActionQuery.UPDATE_BUNDLE_ACTION_STATUS_PENDING_MODTIME, action)); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() { InstrumentUtils.incrJobCounter("bundle_resume", 1, null); @@ -126,9 +117,6 @@ public class BundleJobResumeXCommand extends ResumeTransitionXCommand { BundleJobQuery.UPDATE_BUNDLE_JOB_STATUS_PENDING_SUSP_MOD_TIME, bundleJob)); } - /* (non-Javadoc) - * @see org.apache.oozie.command.ResumeTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { @@ -139,25 +127,16 @@ public class BundleJobResumeXCommand extends ResumeTransitionXCommand { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return bundleId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { jpaService = Services.get().get(JPAService.class); @@ -177,9 +156,6 @@ public class BundleJobResumeXCommand extends ResumeTransitionXCommand { LogUtils.setLogInfo(bundleJob); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { if (bundleJob.getStatus() != Job.Status.SUSPENDED && bundleJob.getStatus() != Job.Status.SUSPENDEDWITHERROR @@ -189,9 +165,6 @@ public class BundleJobResumeXCommand extends ResumeTransitionXCommand { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleJob; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java index 5c3d84e..6251b96 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java @@ -50,31 +50,19 @@ public class BundleJobSuspendXCommand extends SuspendTransitionXCommand { this.jobId = ParamChecker.notEmpty(id, "id"); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#setJob(org.apache.oozie.client.Job) - */ @Override public void setJob(Job job) { } - /* (non-Javadoc) - * @see org.apache.oozie.command.SuspendTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { @@ -85,25 +73,16 @@ public class BundleJobSuspendXCommand extends SuspendTransitionXCommand { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return this.jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { try { @@ -124,9 +103,6 @@ public class BundleJobSuspendXCommand extends SuspendTransitionXCommand { LogUtils.setLogInfo(bundleJob); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { if (bundleJob.getStatus() == Job.Status.SUCCEEDED || bundleJob.getStatus() == Job.Status.FAILED @@ -138,9 +114,6 @@ public class BundleJobSuspendXCommand extends SuspendTransitionXCommand { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() { InstrumentUtils.incrJobCounter("bundle_suspend", 1, null); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java index e11eea0..d11bef8 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java @@ -49,39 +49,24 @@ public class BundleJobXCommand extends XCommand<BundleJobBean> { this.id = ParamChecker.notEmpty(id, "id"); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return this.id; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected BundleJobBean execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java index 09dbdf6..614e422 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java @@ -53,39 +53,24 @@ public class BundleJobsXCommand extends XCommand<BundleJobInfo> { this.len = length; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected BundleJobInfo execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java index de61e5c..05eb70d 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java @@ -36,55 +36,34 @@ public class BundlePauseXCommand extends PauseTransitionXCommand { this.bundleJob = bundleJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return bundleJob.getId(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override public void loadState() throws CommandException { LogUtils.setLogInfo(bundleJob); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() { } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java index 4cd175b..77944ae 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java @@ -82,9 +82,6 @@ public class BundleRerunXCommand extends RerunTransitionXCommand<Void> { this.noCleanup = noCleanup; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { try { @@ -101,9 +98,6 @@ public class BundleRerunXCommand extends RerunTransitionXCommand<Void> { } - /* (non-Javadoc) - * @see org.apache.oozie.command.RerunTransitionXCommand#rerunChildren() - */ @Override public void rerunChildren() throws CommandException { boolean isUpdateActionDone = false; @@ -195,9 +189,6 @@ public class BundleRerunXCommand extends RerunTransitionXCommand<Void> { updateList.add(new UpdateEntry<BundleActionQuery>(BundleActionQuery.UPDATE_BUNDLE_ACTION_PENDING_MODTIME, action)); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() { // rerun a paused bundle job will keep job status at paused and pending at previous pending @@ -216,9 +207,6 @@ public class BundleRerunXCommand extends RerunTransitionXCommand<Void> { updateList.add(new UpdateEntry<BundleJobQuery>(BundleJobQuery.UPDATE_BUNDLE_JOB_STATUS_PENDING, bundleJob)); } - /* (non-Javadoc) - * @see org.apache.oozie.command.RerunTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { @@ -229,42 +217,26 @@ public class BundleRerunXCommand extends RerunTransitionXCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* - * (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.RerunTransitionXCommand#getLog() - */ @Override public XLog getLog() { return LOG; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java index cc98a6d..88de946 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java @@ -81,9 +81,6 @@ public class BundleStartXCommand extends StartTransitionXCommand { this.jobId = ParamChecker.notEmpty(jobId, "jobId"); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return jobId; @@ -94,9 +91,6 @@ public class BundleStartXCommand extends StartTransitionXCommand { return getName() + "_" + jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; @@ -123,9 +117,6 @@ public class BundleStartXCommand extends StartTransitionXCommand { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.StartTransitionXCommand#StartChildren() - */ @Override public void StartChildren() throws CommandException { LOG.debug("Started coord jobs for the bundle=[{0}]", jobId); @@ -134,16 +125,10 @@ public class BundleStartXCommand extends StartTransitionXCommand { LOG.debug("Ended coord jobs for the bundle=[{0}]", jobId); } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() { } - /* (non-Javadoc) - * @see org.apache.oozie.command.StartTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { @@ -343,17 +328,11 @@ public class BundleStartXCommand extends StartTransitionXCommand { return runConf; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() throws CommandException { updateList.add(new UpdateEntry<BundleJobQuery>(BundleJobQuery.UPDATE_BUNDLE_JOB_STATUS_PENDING, bundleJob)); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java index dff2223..80e7d5d 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java @@ -117,9 +117,6 @@ public class BundleSubmitXCommand extends SubmitTransitionXCommand { this.dryrun = dryrun; } - /* (non-Javadoc) - * @see org.apache.oozie.command.SubmitTransitionXCommand#submit() - */ @Override protected String submit() throws CommandException { LOG.info("STARTED Bundle Submit"); @@ -181,24 +178,15 @@ public class BundleSubmitXCommand extends SubmitTransitionXCommand { return this.jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; @@ -406,9 +394,6 @@ public class BundleSubmitXCommand extends SubmitTransitionXCommand { return jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleBean; @@ -507,9 +492,6 @@ public class BundleSubmitXCommand extends SubmitTransitionXCommand { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() throws CommandException { } http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java b/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java index f383316..efa6637 100644 --- a/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java @@ -39,69 +39,34 @@ public class BundleUnpauseXCommand extends UnpauseTransitionXCommand { this.bundleJob = bundleJob; } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return bundleJob.getId(); } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override public void loadState() throws CommandException { LogUtils.setLogInfo(bundleJob); } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() { } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return bundleJob; } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java index e0ccd0f..e6a9c54 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java @@ -55,40 +55,25 @@ public class BulkCoordXCommand extends XCommand<CoordinatorJobInfo> { this.operation = operation; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { loadJobs(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected CoordinatorJobInfo execute() throws CommandException { List<CoordinatorJobBean> jobs = this.coordinatorJobInfo.getCoordJobs(); http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java index 6b849ee..24347ce 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java @@ -77,9 +77,6 @@ public class CoordActionCheckXCommand extends CoordinatorXCommand<Void> { LogUtils.setLogInfo(actionId); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { try { @@ -151,9 +148,6 @@ public class CoordActionCheckXCommand extends CoordinatorXCommand<Void> { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return actionId.substring(0, actionId.indexOf("@")); @@ -164,17 +158,11 @@ public class CoordActionCheckXCommand extends CoordinatorXCommand<Void> { return getName() + "_" + actionId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { try { @@ -197,9 +185,6 @@ public class CoordActionCheckXCommand extends CoordinatorXCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { // if the action has been updated, quit this command http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java index 012fccb..150e702 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java @@ -40,9 +40,6 @@ public class CoordActionInfoXCommand extends CoordinatorXCommand<CoordinatorActi this.id = ParamChecker.notEmpty(id, "id"); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected CoordinatorActionBean execute() throws CommandException { JPAService jpaService = Services.get().get(JPAService.class); @@ -62,31 +59,19 @@ public class CoordActionInfoXCommand extends CoordinatorXCommand<CoordinatorActi } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java index 958194d..9646d73 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java @@ -56,9 +56,6 @@ public class CoordActionTimeOutXCommand extends CoordinatorXCommand<Void> { LogUtils.setLogInfo(actionBean.getId()); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { if (actionBean.getStatus() == CoordinatorAction.Status.WAITING) { @@ -79,9 +76,6 @@ public class CoordActionTimeOutXCommand extends CoordinatorXCommand<Void> { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return actionBean.getJobId(); @@ -92,17 +86,11 @@ public class CoordActionTimeOutXCommand extends CoordinatorXCommand<Void> { return getName() + "_" + actionBean.getId(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { jpaService = Services.get().get(JPAService.class); @@ -119,9 +107,6 @@ public class CoordActionTimeOutXCommand extends CoordinatorXCommand<Void> { LogUtils.setLogInfo(actionBean); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { if (actionBean.getStatus() != CoordinatorAction.Status.WAITING) { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java index ef49ea5..f361070 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java @@ -161,17 +161,11 @@ public class CoordActionUpdateXCommand extends CoordinatorXCommand<Void> { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return workflow.getParentId().substring(0, workflow.getParentId().indexOf("@")); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java index d4c98c8..83c7e2f 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java @@ -139,11 +139,6 @@ public class CoordActionsKillXCommand extends KillTransitionXCommand<Coordinator ret = coordInfo; } - /* - * (non-Javadoc) - * - * @see org.apache.oozie.command.KillTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java index 3b7b664..00ceb9d 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java @@ -341,9 +341,6 @@ public class CoordChangeXCommand extends CoordinatorXCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected Void execute() throws CommandException { LOG.info("STARTED CoordChangeXCommand for jobId=" + jobId); @@ -479,17 +476,11 @@ public class CoordChangeXCommand extends CoordinatorXCommand<Void> { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return this.jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException{ jpaService = Services.get().get(JPAService.class); @@ -510,17 +501,11 @@ public class CoordChangeXCommand extends CoordinatorXCommand<Void> { LogUtils.setLogInfo(this.coordJob); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException,PreconditionException { check(this.coordJob, newEndTime, newConcurrency, newPauseTime, jobStatus); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java index fcc86a8..6cf7c05 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java @@ -88,39 +88,24 @@ public class CoordJobXCommand extends CoordinatorXCommand<CoordinatorJobBean> { this.getActionInfo = getActionInfo; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return this.id; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected CoordinatorJobBean execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java index ab51100..ba703f9 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java @@ -45,39 +45,24 @@ public class CoordJobsXCommand extends CoordinatorXCommand<CoordinatorJobInfo> { this.len = length; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return false; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return null; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#execute() - */ @Override protected CoordinatorJobInfo execute() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java index 92e0dab..abea2b7 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java @@ -111,24 +111,15 @@ public class CoordMaterializeTransitionXCommand extends MaterializeTransitionXCo this.endMatdTime = endTime; } - /* (non-Javadoc) - * @see org.apache.oozie.command.MaterializeTransitionXCommand#transitToNext() - */ @Override public void transitToNext() throws CommandException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() throws CommandException { updateList.add(new UpdateEntry(CoordJobQuery.UPDATE_COORD_JOB_MATERIALIZE,coordJob)); } - /* (non-Javadoc) - * @see org.apache.oozie.command.MaterializeTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { @@ -161,9 +152,6 @@ public class CoordMaterializeTransitionXCommand extends MaterializeTransitionXCo } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return this.jobId; @@ -174,9 +162,6 @@ public class CoordMaterializeTransitionXCommand extends MaterializeTransitionXCo return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { jpaService = Services.get().get(JPAService.class); @@ -283,9 +268,6 @@ public class CoordMaterializeTransitionXCommand extends MaterializeTransitionXCo } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { if (!(coordJob.getStatus() == CoordinatorJobBean.Status.PREP || coordJob.getStatus() == CoordinatorJobBean.Status.RUNNING @@ -351,9 +333,6 @@ public class CoordMaterializeTransitionXCommand extends MaterializeTransitionXCo } - /* (non-Javadoc) - * @see org.apache.oozie.command.MaterializeTransitionXCommand#materialize() - */ @Override protected void materialize() throws CommandException { Instrumentation.Cron cron = new Instrumentation.Cron(); @@ -614,17 +593,11 @@ public class CoordMaterializeTransitionXCommand extends MaterializeTransitionXCo return new DaylightOffsetCalculator(startMatdTime, endMatdTime).calculate(appTz, endTime); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getKey() - */ @Override public String getKey() { return getName() + "_" + jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() throws CommandException { // update bundle action only when status changes in coord job http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java index 985b7a6..6b9e774 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java @@ -39,41 +39,26 @@ public class CoordPauseXCommand extends PauseTransitionXCommand { this.coordJob = coordJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return coordJob.getId(); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override public void loadState() throws CommandException { prevStatus = coordJob.getStatus(); LogUtils.setLogInfo(coordJob); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#notifyParent() - */ @Override public void notifyParent() throws CommandException { // update bundle action @@ -83,17 +68,11 @@ public class CoordPauseXCommand extends PauseTransitionXCommand { } } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return coordJob; } - /* (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#updateJob() - */ @Override public void updateJob() throws CommandException { try { http://git-wip-us.apache.org/repos/asf/oozie/blob/b0f0dc1d/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java index f1509e6..2f158cd 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java @@ -268,25 +268,16 @@ public class CoordRerunXCommand extends RerunTransitionXCommand<CoordinatorActio } } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#getEntityKey() - */ @Override public String getEntityKey() { return jobId; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#isLockRequired() - */ @Override protected boolean isLockRequired() { return true; } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#loadState() - */ @Override protected void loadState() throws CommandException { try { @@ -299,9 +290,6 @@ public class CoordRerunXCommand extends RerunTransitionXCommand<CoordinatorActio LogUtils.setLogInfo(coordJob); } - /* (non-Javadoc) - * @see org.apache.oozie.command.XCommand#verifyPrecondition() - */ @Override protected void verifyPrecondition() throws CommandException, PreconditionException { BundleStatusUpdateXCommand bundleStatusUpdate = new BundleStatusUpdateXCommand(coordJob, coordJob.getStatus()); @@ -414,10 +402,6 @@ public class CoordRerunXCommand extends RerunTransitionXCommand<CoordinatorActio } } - /* - * (non-Javadoc) - * @see org.apache.oozie.command.TransitionXCommand#getJob() - */ @Override public Job getJob() { return coordJob; @@ -448,9 +432,6 @@ public class CoordRerunXCommand extends RerunTransitionXCommand<CoordinatorActio updateList.add(new UpdateEntry<CoordJobQuery>(CoordJobQuery.UPDATE_COORD_JOB_STATUS_PENDING, coordJob)); } - /* (non-Javadoc) - * @see org.apache.oozie.command.RerunTransitionXCommand#performWrites() - */ @Override public void performWrites() throws CommandException { try { @@ -464,9 +445,6 @@ public class CoordRerunXCommand extends RerunTransitionXCommand<CoordinatorActio } } - /* (non-Javadoc) - * @see org.apache.oozie.command.RerunTransitionXCommand#getLog() - */ @Override public XLog getLog() { return LOG;
