This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git
The following commit(s) were added to refs/heads/main by this push:
new 5d62ae97 fix(services/s3): UploadId should be percent encoded (#1690)
5d62ae97 is described below
commit 5d62ae97ca54062134e2bd69abfa435bb5151117
Author: Xuanwo <[email protected]>
AuthorDate: Sun Mar 19 23:47:39 2023 +0800
fix(services/s3): UploadId should be percent encoded (#1690)
* fix(services/s3): UploadId should be percent encoded
Some services like R2 could return a upload id with space
Signed-off-by: Xuanwo <[email protected]>
* Fix CI
Signed-off-by: Xuanwo <[email protected]>
---------
Signed-off-by: Xuanwo <[email protected]>
---
.devcontainer/devcontainer.json | 2 +-
.github/workflows/service_test_azblob.yml | 10 +++++-----
.github/workflows/service_test_azdfs.yml | 10 +++++-----
.github/workflows/service_test_dashmap.yml | 10 +++++-----
.github/workflows/service_test_fs.yml | 10 +++++-----
.github/workflows/service_test_ftp.yml | 10 +++++-----
.github/workflows/service_test_gcs.yml | 10 +++++-----
.github/workflows/service_test_ghac.yml | 10 +++++-----
.github/workflows/service_test_hdfs.yml | 10 +++++-----
.github/workflows/service_test_http.yml | 10 +++++-----
.github/workflows/service_test_ipfs.yml | 10 +++++-----
.github/workflows/service_test_ipmfs.yml | 10 +++++-----
.github/workflows/service_test_memcached.yml | 10 +++++-----
.github/workflows/service_test_memory.yml | 10 +++++-----
.github/workflows/service_test_moka.yml | 10 +++++-----
.github/workflows/service_test_obs.yml | 10 +++++-----
.github/workflows/service_test_oss.yml | 10 +++++-----
.github/workflows/service_test_redis.yml | 10 +++++-----
.github/workflows/service_test_rocksdb.yml | 10 +++++-----
.github/workflows/service_test_s3.yml | 10 +++++-----
.github/workflows/service_test_sled.yml | 10 +++++-----
.github/workflows/service_test_webdav.yml | 10 +++++-----
.github/workflows/service_test_webhdfs.yml | 10 +++++-----
core/src/services/s3/backend.rs | 4 ++--
24 files changed, 113 insertions(+), 113 deletions(-)
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index fd7ffe80..7253f761 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -2,7 +2,7 @@
"name": "OpenDAL",
"image": "ghcr.io/apache/opendal-devtools:latest",
"mounts": [
-
"source=${localEnv:HOME}/.cargo/registry,target=/opt/rust/cargo/registry,type=bind,consistency=cached",
+
"source=${localEnv:HOME}/.cargo/registry,target=/opt/rust/cargo/registry,type=bind,consistency=cached"
],
"remoteUser": "builder",
"updateRemoteUserUID": true,
diff --git a/.github/workflows/service_test_azblob.yml
b/.github/workflows/service_test_azblob.yml
index d74cfb2d..244a4775 100644
--- a/.github/workflows/service_test_azblob.yml
+++ b/.github/workflows/service_test_azblob.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/azblob/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/azblob/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_azdfs.yml
b/.github/workflows/service_test_azdfs.yml
index a6bbf3ea..b72096b5 100644
--- a/.github/workflows/service_test_azdfs.yml
+++ b/.github/workflows/service_test_azdfs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/azdfs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/azdfs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_dashmap.yml
b/.github/workflows/service_test_dashmap.yml
index 70b95777..a286ed26 100644
--- a/.github/workflows/service_test_dashmap.yml
+++ b/.github/workflows/service_test_dashmap.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/dashmap/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/dashmap/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_fs.yml
b/.github/workflows/service_test_fs.yml
index fb347393..bd10e9e5 100644
--- a/.github/workflows/service_test_fs.yml
+++ b/.github/workflows/service_test_fs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/fs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_ftp.yml
b/.github/workflows/service_test_ftp.yml
index 674caa2e..6f98d8ce 100644
--- a/.github/workflows/service_test_ftp.yml
+++ b/.github/workflows/service_test_ftp.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/ftp/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/ftp/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_gcs.yml
b/.github/workflows/service_test_gcs.yml
index 656b23b5..8186b9c6 100644
--- a/.github/workflows/service_test_gcs.yml
+++ b/.github/workflows/service_test_gcs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/gcs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/gcs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_ghac.yml
b/.github/workflows/service_test_ghac.yml
index 51fc4149..3a85d476 100644
--- a/.github/workflows/service_test_ghac.yml
+++ b/.github/workflows/service_test_ghac.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/ghac/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/ghac/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_hdfs.yml
b/.github/workflows/service_test_hdfs.yml
index df9f9682..963a4748 100644
--- a/.github/workflows/service_test_hdfs.yml
+++ b/.github/workflows/service_test_hdfs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/hdfs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/hdfs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_http.yml
b/.github/workflows/service_test_http.yml
index 5cf032ce..c9617046 100644
--- a/.github/workflows/service_test_http.yml
+++ b/.github/workflows/service_test_http.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/http/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/http/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_ipfs.yml
b/.github/workflows/service_test_ipfs.yml
index ee9f76ec..ae300d7a 100644
--- a/.github/workflows/service_test_ipfs.yml
+++ b/.github/workflows/service_test_ipfs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/ipfs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/ipfs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_ipmfs.yml
b/.github/workflows/service_test_ipmfs.yml
index 4c7814f7..25b4b7bd 100644
--- a/.github/workflows/service_test_ipmfs.yml
+++ b/.github/workflows/service_test_ipmfs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/ipmfs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/ipmfs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_memcached.yml
b/.github/workflows/service_test_memcached.yml
index 1ea0d37c..5e4c6bcb 100644
--- a/.github/workflows/service_test_memcached.yml
+++ b/.github/workflows/service_test_memcached.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/memcached/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/memcached/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_memory.yml
b/.github/workflows/service_test_memory.yml
index 614570cf..0e0d5b62 100644
--- a/.github/workflows/service_test_memory.yml
+++ b/.github/workflows/service_test_memory.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/memory/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/memory/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_moka.yml
b/.github/workflows/service_test_moka.yml
index 5b17b2f8..2e1c2196 100644
--- a/.github/workflows/service_test_moka.yml
+++ b/.github/workflows/service_test_moka.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/moka/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/moka/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_obs.yml
b/.github/workflows/service_test_obs.yml
index d41a0f91..70c374fb 100644
--- a/.github/workflows/service_test_obs.yml
+++ b/.github/workflows/service_test_obs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/obs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/obs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_oss.yml
b/.github/workflows/service_test_oss.yml
index 4f474f4c..dc6779b9 100644
--- a/.github/workflows/service_test_oss.yml
+++ b/.github/workflows/service_test_oss.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/oss/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/oss/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_redis.yml
b/.github/workflows/service_test_redis.yml
index bbe1cf05..0d807e82 100644
--- a/.github/workflows/service_test_redis.yml
+++ b/.github/workflows/service_test_redis.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/redis/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/redis/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_rocksdb.yml
b/.github/workflows/service_test_rocksdb.yml
index 6a855827..656fd428 100644
--- a/.github/workflows/service_test_rocksdb.yml
+++ b/.github/workflows/service_test_rocksdb.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/rocksdb/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/rocksdb/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_s3.yml
b/.github/workflows/service_test_s3.yml
index d60cbf2c..e48af41f 100644
--- a/.github/workflows/service_test_s3.yml
+++ b/.github/workflows/service_test_s3.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/s3/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/s3/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_sled.yml
b/.github/workflows/service_test_sled.yml
index 6ac54b08..0e559819 100644
--- a/.github/workflows/service_test_sled.yml
+++ b/.github/workflows/service_test_sled.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/sled/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/sled/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_webdav.yml
b/.github/workflows/service_test_webdav.yml
index dfb82b78..b8bac82f 100644
--- a/.github/workflows/service_test_webdav.yml
+++ b/.github/workflows/service_test_webdav.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/webdav/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/webdav/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/.github/workflows/service_test_webhdfs.yml
b/.github/workflows/service_test_webhdfs.yml
index eadd2dab..80c67fea 100644
--- a/.github/workflows/service_test_webhdfs.yml
+++ b/.github/workflows/service_test_webhdfs.yml
@@ -25,11 +25,11 @@ on:
branches:
- main
paths:
- - "src/**"
- - "tests/**"
- - "!src/docs/**"
- - "!src/services/**"
- - "src/services/webhdfs/**"
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/webhdfs/**"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
diff --git a/core/src/services/s3/backend.rs b/core/src/services/s3/backend.rs
index 633a633d..5cf12bfd 100644
--- a/core/src/services/s3/backend.rs
+++ b/core/src/services/s3/backend.rs
@@ -1505,7 +1505,7 @@ impl S3Backend {
self.endpoint,
percent_encode_path(&p),
part_number,
- upload_id
+ percent_encode_path(upload_id)
);
let mut req = Request::put(&url);
@@ -1535,7 +1535,7 @@ impl S3Backend {
"{}/{}?uploadId={}",
self.endpoint,
percent_encode_path(&p),
- upload_id
+ percent_encode_path(upload_id)
);
let req = Request::post(&url);
