ahonn commented on PR #1986:
URL:
https://github.com/apache/incubator-opendal/pull/1986#issuecomment-1508070472
> Test failed for
>
> ```rust
> error: this function has too many arguments (8/7)
> --> core/src/services/oss/core.rs:110:5
> |
> 110 | / pub fn oss_put_object_request(
> 111 | | &self,
> 112 | | path: &str,
> 113 | | size: Option<usize>,
> ... |
> 118 | | is_presign: bool,
> 119 | | ) -> Result<Request<AsyncBody>> {
> | |___________________________________^
> |
> = note: `-D clippy::too-many-arguments` implied by `-D warnings`
> = help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
> ```
>
> Please ignore this error by adding a
`#[allow(clippy::too_many_arguments)]`. We will refactor this part later.
Sure, error ignored.
And maybe we need a struct like `OssHeaders` to handle that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
