Xuanwo commented on code in PR #2192:
URL: 
https://github.com/apache/incubator-opendal/pull/2192#discussion_r1187001497


##########
core/src/services/sftp/pager.rs:
##########
@@ -15,77 +15,76 @@
 // specific language governing permissions and limitations
 // under the License.
 
+use std::pin::Pin;
+
 use async_trait::async_trait;
+use futures::StreamExt;
 use openssh_sftp_client::fs::DirEntry;
+use openssh_sftp_client::fs::ReadDir;
 
 use crate::raw::oio;
 use crate::Result;
 
-pub struct SftpPager {
-    dir: Box<[DirEntry]>,
-    path: String,
-    limit: Option<usize>,
-    complete: bool,
+pub enum SftpPager {

Review Comment:
   `oio::Page` has been implemented on all `Option<T: oio::Page>`. So you can 
use `Option<SftpPager>` directly without wrap again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to