godruoyi commented on code in PR #2782:
URL:
https://github.com/apache/incubator-opendal/pull/2782#discussion_r1284977343
##########
bindings/php/src/lib.rs:
##########
@@ -15,14 +15,165 @@
// specific language governing permissions and limitations
// under the License.
+use std::collections::HashMap;
+use std::str::FromStr;
use ext_php_rs::prelude::*;
-use opendal::{EntryMode, Metadata};
+use ext_php_rs::{exception::PhpException, zend::ce};
+use ext_php_rs::convert::FromZval;
+use ext_php_rs::flags::DataType;
+use ext_php_rs::types::Zval;
+use ::opendal as od;
-#[php_function]
-pub fn debug() -> String {
- let metadata = Metadata::new(EntryMode::FILE);
+#[php_class(name = "OpenDAL\\Operator")]
Review Comment:
From my understanding, I think there are NO async in PHP. If we find out
later that we can support asynchronous calls, we can add it in the future PR.
For now, let's stay with synchronous calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
