NobodyXu commented on PR #2780:
URL: 
https://github.com/apache/incubator-opendal/pull/2780#issuecomment-1666847092

   > It seems that the dropping of sftp client does some magical things.
   > 
   > ```
   > thread '<unnamed>' panicked at 'there is no reactor running, must be 
called from the context of a Tokio 1.x runtime', 
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/openssh-sftp-client-0.13.6/src/file/tokio_compat_file.rs:763:9
   > ```
   
   
[`TokioCompatFile::drop`](https://docs.rs/openssh-sftp-client/latest/src/openssh_sftp_client/file/tokio_compat_file.rs.html#763)
 calls `tokio::spawn` to wait on all `write_futures` and log the errors if any.
   
   We can change it to only do that if a `tokio::Runtime` is available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to