[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2803: feat: Add async list with metakey support

Mon, 07 Aug 2023 01:45:11 -0700 


Xuanwo commented on code in PR #2803:
URL: 
https://github.com/apache/incubator-opendal/pull/2803#discussion_r1285566260


##########
bin/oay/src/services/s3/service.rs:
##########
@@ -103,21 +104,18 @@ async fn handle_list_objects(
         .op
         .lister_with(&params.prefix)
         .start_after(&params.start_after)
-        .await?;
+        .metakey(Metakey::Mode | Metakey::LastModified | Metakey::Etag | 
Metakey::ContentLength)
+        .await?
+        .chunks(1000);
 
-    let page = lister.next_page().await?.unwrap_or_default();
+    let page = lister.next().await.unwrap_or_default();
 
-    let is_truncated = lister.has_next().await?;
+    let is_truncated = page.len() >= 1000;

Review Comment:
   No, we should not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to