flaneur2020 opened a new pull request, #3246: URL: https://github.com/apache/incubator-opendal/pull/3246
in the previous PR I converted the metrics in PrometheusLayer as it into PrometheusClientLayer, however I missed an important metric not included in the PrometheusLayer before is the bytes total metrics. we already have a histogram about the bytes which is useful for us to find out the distribution of the size on different IO requests. however, a bytes metric in counter is more useful for us to get the IO bandwidth infomation, which is important for us to diagnose the issues on IO. this PR also fixed a naming issue about counters in PrometheusClientLayer, the prometheus-client tend to append a `_total` suffix in a dump way for every counters, if we name a counter as `opendal_errors_total` what we finally get is `opendal_errors_total_total`, which is bad :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
