(incubator-opendal) branch main updated: fix(ci): try enable corepack before setup-node action (#3609)

[xuanwo]

This is an automated email from the ASF dual-hosted git repository.

xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git


The following commit(s) were added to refs/heads/main by this push:
     new cdce98170 fix(ci): try enable corepack before setup-node action (#3609)
cdce98170 is described below

commit cdce981704e18839dba51dc4643249582a5638d3
Author: Suyan <suyanh...@gmail.com>
AuthorDate: Fri Nov 17 22:21:53 2023 +0800

    fix(ci): try enable corepack before setup-node action (#3609)
---
 .github/services/redis/redis_with_cluster_tls/action.yml | 1 -
 .github/workflows/behavior_test_binding_nodejs.yml       | 7 ++++---
 .github/workflows/docs.yml                               | 6 +++---
 bindings/nodejs/src/lib.rs                               | 1 +
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/services/redis/redis_with_cluster_tls/action.yml 
b/.github/services/redis/redis_with_cluster_tls/action.yml
index e01335c27..b2f7216c4 100644
--- a/.github/services/redis/redis_with_cluster_tls/action.yml
+++ b/.github/services/redis/redis_with_cluster_tls/action.yml
@@ -27,7 +27,6 @@ runs:
       shell: bash
       working-directory: fixtures/redis
       run: |
-
         # Install the CA in the system
 
         sudo cp ssl/ca.crt /usr/local/share/ca-certificates
diff --git a/.github/workflows/behavior_test_binding_nodejs.yml 
b/.github/workflows/behavior_test_binding_nodejs.yml
index 0060d75cb..f3879154d 100644
--- a/.github/workflows/behavior_test_binding_nodejs.yml
+++ b/.github/workflows/behavior_test_binding_nodejs.yml
@@ -54,14 +54,15 @@ jobs:
           connect-host: ${{ secrets.OP_CONNECT_HOST }}
           connect-token: ${{ secrets.OP_CONNECT_TOKEN }}
 
+      - name: Corepack
+        working-directory: bindings/nodejs
+        run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: '18'
           cache: yarn
           cache-dependency-path: "bindings/nodejs/yarn.lock"
-      - name: Corepack
-        working-directory: bindings/nodejs
-        run: corepack enable
+
       - name: Install dependencies
         working-directory: bindings/nodejs
         run: yarn install --immutable
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index b0a88f8e6..23a3cab17 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -90,15 +90,15 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      - name: Corepack
+        working-directory: bindings/nodejs
+        run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: '18'
           cache: yarn
           cache-dependency-path: "bindings/nodejs/yarn.lock"
 
-      - name: Corepack
-        working-directory: bindings/nodejs
-        run: corepack enable
       - name: Install dependencies
         working-directory: bindings/nodejs
         run: yarn install --immutable
diff --git a/bindings/nodejs/src/lib.rs b/bindings/nodejs/src/lib.rs
index 3cb8b8670..20e46d7e2 100644
--- a/bindings/nodejs/src/lib.rs
+++ b/bindings/nodejs/src/lib.rs
@@ -821,6 +821,7 @@ impl RetryLayer {
     }
 }
 
+/// Format opendal error to napi error.
 fn format_napi_error(err: opendal::Error) -> Error {
     Error::from_reason(format!("{}", err))
 }