jorgehermo9 commented on code in PR #5274:
URL: https://github.com/apache/opendal/pull/5274#discussion_r1826556039
##########
core/src/services/azblob/backend.rs:
##########
@@ -545,7 +548,17 @@ impl Access for AzblobBackend {
let status = resp.status();
match status {
- StatusCode::OK => parse_into_metadata(path,
resp.headers()).map(RpStat::new),
+ StatusCode::OK => {
+ let headers = resp.headers();
+ let mut meta = parse_into_metadata(path, headers)?;
+
+ let user_meta = parse_prefixed_headers(&headers,
X_MS_META_NAME_PREFIX);
Review Comment:
Should the metadata parsing be done in two steps (first call
`parse_into_metadata` and then `parse_prefixed_headers`) or should we add a new
`prefix: Optional<&str>` parameter to the `parse_into_metadata` function and
the prefixed headers parsing will be done there (and also the
`meta.with_user_metadata` call, as the `parse_into_metadata` returns a
`Metadata` struct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
