yihong0618 commented on PR #5563:
URL: https://github.com/apache/opendal/pull/5563#issuecomment-2601797873
> Hi, I don't think it's good to skip doc test. I prefer to fix the
contributing guide instead.
yes but this doctest I think its better to ignore here, cause for developers
the most simple and intuitions do is `cargo build` and `cargo test`
and for now for opendal I do not see any directly doctest in the repo and
actions.
and for the `contributing guide` part
the way run all the unit tests is `cargo test --features tests`, but for the
most os and developers part is also hard to run, for
example user need to install foundationdb like the GitHun Actions did, which
is hard.
```
- name: Build foundationdb if not cached
if: steps.cache-foundationdb.outputs.cache-hit != 'true' && runner.os
== 'Linux' && inputs.need-foundationdb == 'true'
shell: bash
run: |
set -e
cd /tmp
curl
https://github.com/apple/foundationdb/releases/download/7.1.17/foundationdb-clients_7.1.17-1_amd64.deb
-L -o foundationdb-clients_7.1.17-1_amd64.deb
curl
https://github.com/apple/foundationdb/releases/download/7.1.17/foundationdb-server_7.1.17-1_amd64.deb
-L -o foundationdb-server_7.1.17-1_amd64.deb
sudo dpkg -i foundationdb-clients_7.1.17-1_amd64.deb
foundationdb-server_7.1.17-1_amd64.deb
rm foundationdb-clients_7.1.17-1_amd64.deb
rm foundationdb-server_7.1.17-1_amd64.deb
```
and issue can track https://github.com/apache/opendal/issues/4187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
