jorgehermo9 commented on code in PR #6063:
URL: https://github.com/apache/opendal/pull/6063#discussion_r2051703445
##########
core/src/services/aliyun_drive/backend.rs:
##########
@@ -370,7 +370,9 @@ impl Access for AliyunDriveBackend {
serde_json::from_reader(res.reader()).map_err(new_json_serialize_error)?;
let download_url = self.core.get_download_url(&file.file_id).await?;
+ // TODO: this request should be done in core.rs and not here
Review Comment:
I left this TODO since I think we should refactor this and this request
needs to be in `core.rs`. `get_download_url` should be renamed to something
like `download_file` that both gets the download url & downloads it in the same
function, right?
Should I refactor that in this PR? or leave the TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
