jorgehermo9 commented on code in PR #6089:
URL: https://github.com/apache/opendal/pull/6089#discussion_r2062559692
##########
core/src/services/aliyun_drive/backend.rs:
##########
@@ -368,16 +366,8 @@ impl Access for AliyunDriveBackend {
let res = self.core.get_by_path(path).await?;
let file: AliyunDriveFile =
serde_json::from_reader(res.reader()).map_err(new_json_serialize_error)?;
+ let resp = self.core.download(&file.file_id, args.range()).await?;
- let download_url = self.core.get_download_url(&file.file_id).await?;
Review Comment:
Refactored this as @erickguan suggested
https://github.com/apache/opendal/pull/6089#discussion_r2061588886
##########
core/src/services/aliyun_drive/writer.rs:
##########
@@ -81,23 +80,11 @@ impl oio::Write for AliyunDriveWriter {
}
};
- let res = self
+ if let Err(err) = self
.core
- .get_upload_url(file_id, upload_id, Some(self.part_number))
Review Comment:
Refactored this as @erickguan suggested
https://github.com/apache/opendal/pull/6089#discussion_r2061588886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
