YichiZhang0613 commented on code in PR #6375:
URL: https://github.com/apache/opendal/pull/6375#discussion_r2192782317
##########
bindings/nodejs/src/lib.rs:
##########
@@ -1180,6 +1180,7 @@ impl RetryLayer {
/// This function will panic if the input factor is smaller than `1.0`.
Review Comment:
> if so we can drop this comment but is it need to add assert here? instead
of just let it panic?
Based on the commit history, it seems that the comment updated the
constraint, but the code didn't add the corresponding check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
