BurntSushi commented on code in PR #642: URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2395363187
########## core/Cargo.toml: ########## @@ -17,31 +17,30 @@ [package] name = "reqsign-core" -version = "1.0.0" +version = "1.1.0" Review Comment: Didn't y'all switch over to Jiff entire, including [changing the definition of a public type alias](https://docs.rs/reqsign-core/latest/reqsign_core/time/type.DateTime.html)? And consequently, the inputs and outputs of the various functions in `reqsign_core::time`. That isn't minor breakage. You absolutely have to do a 2.0 release. ########## core/Cargo.toml: ########## @@ -17,31 +17,30 @@ [package] name = "reqsign-core" -version = "1.0.0" +version = "1.1.0" Review Comment: Didn't y'all switch over to Jiff entirely, including [changing the definition of a public type alias](https://docs.rs/reqsign-core/latest/reqsign_core/time/type.DateTime.html)? And consequently, the inputs and outputs of the various functions in `reqsign_core::time`. That isn't minor breakage. You absolutely have to do a 2.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
