TennyZhuang commented on code in PR #6679:
URL: https://github.com/apache/opendal/pull/6679#discussion_r2435755964
##########
bindings/python/python/opendal/__init__.pyi:
##########
@@ -381,6 +393,18 @@ class AsyncOperator(_Base):
-------
None
"""
+ async def delete_many(self, paths: Iterable[PathBuf]) -> None:
Review Comment:
I've updated it according to your suggestion, but I feel the updated code is
a bit complex.
There are two ways to achieve this goal:
Use the current approach in the PR, hack the function in the Python layer to
do forwarding.
Accept a generic object as a parameter in Rust, then check the PyType type
in Rust and forward accordingly.
Both methods significantly impact readability and seem to introduce
unnecessary complexity. If you agree, I can roll back this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
