erickguan commented on code in PR #6627:
URL: https://github.com/apache/opendal/pull/6627#discussion_r2412714216
##########
bindings/ruby/Cargo.toml:
##########
@@ -36,7 +36,7 @@ name = "opendal_ruby"
magnus = { version = "0.8", features = ["bytes", "io"] }
# 1. this crate won't be published, we always use the local version
# 2. we use the symbolink to allow released gem to find core's source files.
-opendal = { version = ">=0", path = "./core", features = [
+opendal = { version = ">=0", path = "../../core", features = [
Review Comment:
The problem is that distributed gem can't look into parent directory for
security reasons.
@tisonkun do you have a way to resolve this based on dev/distributed
environment?
##########
.github/workflows/release_ruby.yml:
##########
@@ -20,7 +20,9 @@ name: Release Ruby Binding
on:
push:
tags:
- - 'v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+' # Triggers on version tags (v0.54.0,
v0.54.0-rc.1, etc.)
+ # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.)
+ - 'v[0-9]+.[0-9]+.[0-9]+'
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
