dami0806 commented on code in PR #6650:
URL: https://github.com/apache/opendal/pull/6650#discussion_r2423805720
##########
bindings/c/src/metadata.rs:
##########
@@ -131,7 +131,9 @@ impl opendal_metadata {
let mtime = self.deref().last_modified();
match mtime {
None => -1,
- Some(time) => time.as_millisecond(),
+ Some(time) => {
+ time.as_second() * 1000 + (time.subsec_nanosecond() /
1_000_000) as i64
+ }
Review Comment:
While updating multiple bindings at once, I missed the temporary workaround
I had added earlier for millisecond calculation and forgot to revert it... I’m
sorry for the confusion this caused during review.
I will fix this immediately as follows:
Add a pub fn as_millisecond() method to the opendal::raw::Timestamp wrapper.
Replace the temporary calculation in the C binding with
time.as_millisecond() for clarity and consistency.
I’ll be more careful and thorough in my future reviews and testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
