reonokiy commented on PR #4591: URL: https://github.com/apache/opendal/pull/4591#issuecomment-3406350507
Hi, I've tested this PR and applied some fixes to make it work with shared Google Drives. My code is in this branch: https://github.com/reonokiy/opendal/tree/shared-gdrive. I have also run the behavior tests with the required envs. ``` OPENDAL_GDRIVE_ACCESS_TOKEN=xxxxxxxxxxxxx OPENDAL_GDRIVE_ROOT=test OPENDAL_TEST=gdrive OPENDAL_GDRIVE_DRIVE_ID=xxxxxxxxxxxx ``` logs: ``` running 105 tests test behavior::test_delete_stream ... ok test behavior::test_delete_with_version ... ok test behavior::test_delete_with_not_existing_version ... ok test behavior::test_batch_delete ... ok test behavior::test_batch_delete_with_version ... ok test behavior::test_list_rich_dir ... ok test behavior::test_list_with_start_after ... ok test behavior::test_list_files_with_versions ... ok test behavior::test_list_with_versions_and_limit ... ok test behavior::test_list_with_versions_and_start_after ... ok test behavior::test_list_files_with_deleted ... ok test behavior::test_copy_source_dir ... ok test behavior::test_reader_with_if_match ... ok test behavior::test_reader_with_if_none_match ... ok test behavior::test_reader_with_if_modified_since ... ok test behavior::test_reader_with_if_unmodified_since ... ok test behavior::test_copy_non_existing_source ... ok test behavior::test_read_with_if_match ... ok test behavior::test_read_with_if_none_match ... ok test behavior::test_read_with_if_modified_since ... ok test behavior::test_read_with_if_unmodified_since ... ok test behavior::test_list_non_exist_dir_with_recursive ... ok test behavior::test_read_with_dir_path ... ok test behavior::test_read_with_override_cache_control ... ok test behavior::test_read_with_override_content_disposition ... ok test behavior::test_read_with_override_content_type ... ok test behavior::test_read_with_version ... ok test behavior::test_read_with_not_existing_version ... ok test behavior::test_create_dir ... ok test behavior::test_list_root_with_recursive ... FAILED test behavior::test_delete_not_existing ... ok test behavior::test_list_non_exist_dir ... ok test behavior::test_create_dir_existing ... ok test behavior::test_read_not_exist ... ok test behavior::test_check ... ok test behavior::test_rename_source_dir ... ok test behavior::test_list_empty_dir ... FAILED test behavior::test_rename_non_existing_source ... ok test behavior::test_list_sub_dir ... FAILED test behavior::test_stat_dir ... ok test behavior::test_stat_not_exist ... ok test behavior::test_stat_with_if_match ... ok test behavior::test_stat_with_if_none_match ... ok test behavior::test_stat_with_if_modified_since ... ok test behavior::test_stat_with_if_unmodified_since ... ok test behavior::test_stat_with_override_cache_control ... ok test behavior::test_stat_with_override_content_disposition ... ok test behavior::test_stat_with_override_content_type ... ok test behavior::test_stat_root ... ok test behavior::test_stat_with_version ... ok test behavior::stat_with_not_existing_version ... ok test behavior::test_stat_not_cleaned_path ... ok test behavior::test_write_with_empty_content ... ok test behavior::test_write_with_dir_path ... ok test behavior::test_delete_empty_dir ... ok test behavior::test_write_with_cache_control ... ok test behavior::test_write_with_content_type ... ok test behavior::test_write_with_content_disposition ... ok test behavior::test_write_with_content_encoding ... ok test behavior::test_write_with_if_none_match ... ok test behavior::test_write_with_if_not_exists ... ok test behavior::test_write_with_if_match ... ok test behavior::test_write_with_user_metadata ... ok test behavior::test_copy_self ... ok test behavior::test_writer_write ... ok test behavior::test_stat_file ... ok test behavior::test_writer_write_with_concurrent ... ok test behavior::test_writer_sink ... ok test behavior::test_writer_sink_with_concurrent ... ok test behavior::test_read_full ... ok test behavior::test_read_range ... ok test behavior::test_writer_futures_copy ... ok test behavior::test_writer_futures_copy_with_concurrent ... ok test behavior::test_writer_return_metadata ... ok test behavior::test_delete_with_special_chars ... ok test behavior::test_rename_self ... ok test behavior::test_writer_abort ... ok test behavior::test_list_prefix ... FAILED test behavior::test_writer_abort_with_concurrent ... ok test behavior::test_reader ... ok test behavior::test_write_only ... ok test behavior::test_delete_file ... ok test behavior::test_list_dir_with_file_path ... FAILED test behavior::test_stat_with_special_chars ... ok test behavior::test_stat_nested_parent_dir ... ok test behavior::test_write_with_special_chars ... ok test behavior::test_write_returns_metadata ... ok test behavior::test_read_with_special_chars ... ok test behavior::test_rename_target_dir ... ok test behavior::test_copy_target_dir ... ok test behavior::test_list_dir ... ok test behavior::test_copy_file_with_ascii_name ... ok test behavior::test_copy_file_with_non_ascii_name ... ok test behavior::test_list_file_with_recursive ... FAILED test behavior::test_remove_one_file ... ok test behavior::test_list_nested_dir ... ok test behavior::test_rename_nested ... ok test behavior::test_writer_write_with_overwrite ... ok test behavior::test_copy_nested ... ok test behavior::test_rename_file ... ok test behavior::test_copy_overwrite ... ok test behavior::test_rename_overwrite ... ok test behavior::test_list_dir_with_recursive ... ok test behavior::test_list_dir_with_recursive_no_trailing_slash ... ok test behavior::test_remove_all ... ok failures: ---- behavior::test_list_root_with_recursive ---- test panicked: empty root should return itself ---- behavior::test_list_empty_dir ---- test panicked: assertion `left == right` failed: only return the dir itself, but found: {} left: 0 right: 1 ---- behavior::test_list_sub_dir ---- test panicked: dir should be found in list, but only got: [Entry { path: "/", metadata: Metadata { mode: DIR, is_current: None, is_deleted: false, cache_control: None, content_disposition: None, content_length: None, content_md5: None, content_range: None, content_type: None, content_encoding: None, etag: None, last_modified: None, version: None, user_metadata: None } }] ---- behavior::test_list_prefix ---- test panicked: assertion `left == right` failed left: 0 right: 1 ---- behavior::test_list_dir_with_file_path ---- test panicked: assertion `left == right` failed left: 0 right: 1 ---- behavior::test_list_file_with_recursive ---- test panicked: assertion `left == right` failed left: ["y", "y", "yy"] right: ["y", "yy"] failures: behavior::test_list_root_with_recursive behavior::test_list_empty_dir behavior::test_list_sub_dir behavior::test_list_prefix behavior::test_list_dir_with_file_path behavior::test_list_file_with_recursive test result: FAILED. 99 passed; 6 failed; 0 ignored; 0 measured; 0 filtered out; finished in 103.83s ``` Some of the tests seem to be failing randomly when they're run together. However, they work fine when I run them individually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
