This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/opendal.git
The following commit(s) were added to refs/heads/main by this push:
new c507e3181 fix:(bindings/python) Gate service-sftp on windows targets
(#6777)
c507e3181 is described below
commit c507e3181c2060701a950c879b6abf01b5f2d4a1
Author: Chitral Verma <[email protected]>
AuthorDate: Thu Nov 13 16:48:04 2025 +0530
fix:(bindings/python) Gate service-sftp on windows targets (#6777)
* Conditionally include sftp feature
Include the sftp feature in services-all on non-windows targets.
* Update bindings/python/Cargo.toml
---------
Co-authored-by: Xuanwo <[email protected]>
---
bindings/python/Cargo.toml | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/bindings/python/Cargo.toml b/bindings/python/Cargo.toml
index 7a264e1c7..e3d4c3d6a 100644
--- a/bindings/python/Cargo.toml
+++ b/bindings/python/Cargo.toml
@@ -75,7 +75,6 @@ services-all = [
'services-redb',
'services-redis',
'services-seafile',
- 'services-sftp',
'services-sled',
'services-sqlite',
'services-swift',
@@ -181,6 +180,10 @@ services-yandex-disk = ["opendal/services-yandex-disk"]
# we build cp311-abi3 and cp310 wheels now, move this to pyo3 after we drop
cp310
abi3 = ["pyo3/abi3-py311"]
+# Conditionally include sftp only on non-windows targets
+[target.'cfg(not(windows))'.features]
+services-all = ["services-sftp"]
+
[[bin]]
doc = false
name = "stub_gen"
@@ -205,18 +208,6 @@ pyo3-async-runtimes = { version = "0.26.0", features =
["tokio-runtime"] }
pyo3-stub-gen = { version = "0.16" }
tokio = "1"
-[target.'cfg(unix)'.dependencies.opendal]
-features = [
- "blocking",
- "layers-mime-guess",
- # Depend on "openssh" which depends on "tokio-pipe" that is unavailable on
Windows.
- #
- # FIXME: waiting for https://github.com/NobodyXu/concurrent_arena/issues/25
- # "services-sftp",
-]
-path = "../../core"
-version = ">=0"
-
[profile.release]
codegen-units = 1
debug = false
