tisonkun commented on code in PR #6820:
URL: https://github.com/apache/opendal/pull/6820#discussion_r2559737816


##########
core/src/services/memcached/backend.rs:
##########
@@ -85,7 +85,7 @@ impl MemcachedBuilder {
     ///
     /// Will panic if `max_size` is 0.
     #[must_use]
-    pub fn connection_pool_max_size(mut self, max_size: u32) -> Self {
+    pub fn connection_pool_max_size(mut self, max_size: usize) -> Self {

Review Comment:
   This is a breaking change but I think it's OK. Our next version would be 
thus 0.56.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to