Copilot commented on code in PR #6877:
URL: https://github.com/apache/opendal/pull/6877#discussion_r2597698510
##########
core/Cargo.toml:
##########
@@ -26,7 +26,6 @@ members = [
"benches/vs_*",
"services/*",
"layers/*",
- "layers/await-tree",
]
Review Comment:
The workspace member `"layers/await-tree"` is being removed from the members
list, but this directory still exists and is referenced elsewhere in the file
(line 165: `opendal-layer-await-tree = { path = "layers/await-tree", version =
"0.55.0", optional = true, default-features = false }`).
If this is a formatting change by taplo, it suggests this entry might be
redundant since `"layers/*"` on line 28 already includes all layers. However,
removing it could be unintentional if it was explicitly listed for a reason.
Please verify this is the intended behavior of your taplo configuration.
##########
bindings/nodejs/Cargo.toml:
##########
@@ -82,7 +82,6 @@ services-all = [
"services-mongodb",
"services-gridfs",
"services-sqlite",
- "services-alluxio",
"services-b2",
Review Comment:
The feature `"services-alluxio"` is being removed from the `services-all`
feature list on line 85, but it still appears to have its own feature
definition later in the file. Additionally, `"services-compfs"` is being moved
from line 148 to line 114 (in alphabetical order).
If taplo is removing `services-alluxio` from `services-all`, this could be
unintentional behavior unless the service is deliberately being excluded.
Please verify that:
1. Removing `services-alluxio` from `services-all` is intended
2. This is expected behavior from your taplo configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
