Xuanwo commented on code in PR #6964:
URL: https://github.com/apache/opendal/pull/6964#discussion_r2609487781
##########
core/core/Cargo.toml:
##########
@@ -354,3 +354,4 @@ tracing-subscriber = { version = "0.3", features = [
"env-filter",
"tracing-log",
] }
+opendal-layer-timeout = { path = "../layers/timeout", version = "0.55.0",
default-features = false }
Review Comment:
core should not depend on this layer.
##########
core/core/src/docs/performance/http_optimization.md:
##########
@@ -106,10 +106,10 @@ let client = reqwest::ClientBuilder::new()
let op = op.layer(HttpClientLayer::new(HttpClient::with(client)));
```
-It's also recommended to use opendal's
[`TimeoutLayer`][crate::layers::TimeoutLayer] to prevent slow requests hangs
forever. This layer will automatically cancel the request if it takes too long
to complete.
+It's also recommended to use opendal's [`TimeoutLayer`] to prevent slow
requests hangs forever. This layer will automatically cancel the request if it
takes too long to complete.
Review Comment:
Seems not updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
