dheeraj12347 opened a new pull request, #7179: URL: https://github.com/apache/opendal/pull/7179
This PR is a complete refactor of the TimeoutLayer to address the architectural feedback from my previous attempt in #7176. The Problem: My previous PR attempted to add timeout parameters to the operation arguments (ops), which leaked layer logic into the core. The Solution: This version uses the Decorator pattern to wrap the futures directly within the TimeoutAccessor and TimeoutWrapper. Key Changes: Encapsulation: All tokio::time::timeout logic is now internal to the layer. Zero Core Changes: No modifications were made to opendal_core::raw::ops. Standardized Errors: Timeout errors now include duration context and are marked as temporary to support retry layers. Verified: Included unit tests to confirm that operation timeouts trigger correctly. I would appreciate a fresh review of this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
