frostming commented on code in PR #7181: URL: https://github.com/apache/opendal/pull/7181#discussion_r2768790662
########## bindings/python/python/opendal/__init__.py: ########## @@ -18,31 +18,16 @@ # ruff: noqa: D104 from __future__ import annotations -from typing import TYPE_CHECKING - -if TYPE_CHECKING: - __version__: str - from opendal import capability, exceptions, file, layers, services, types -else: - from opendal._opendal import ( - __version__, # noqa: F401 - capability, - exceptions, - file, - layers, - services, - types, - ) - -from opendal.operator import AsyncOperator, Operator # pyright:ignore +from opendal._opendal import * # ty: ignore +from opendal.operator import AsyncOperator, Operator Review Comment: No, it reverts my change and the typecheckers can't find types, because `opendal._opendal` is not typed. In fact I don't understand why you moved *.pyi into its own package. it looks less clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
