antoine-de opened a new pull request, #7186: URL: https://github.com/apache/opendal/pull/7186
This default ACL is used when creating an object. Note: I did not use a fixed list for the ACL but a String since I'm not an expert on this, and I don't really know if, for all supported services, we can restrict it the list of [canned ACL](https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html#canned-acl). Also note that not all s3 providers support those ACL. Amazon does, OVH also, but not minio for example (cf [issue](https://github.com/minio/minio/issues/8195))/ I did not add any tests, as I don't really see test specific for s3 and also because minio, used in the tests do not support this. I only tested this manually (using the python bindings, since this is what I will use), and the objects created have the right ACL. I can add tests if needed and if someone can point me how to add those. # Which issue does this PR close? Closes #5358 # Rationale for this change Even if ACL are deprecated, they can be handy in many situations. # Are there any user-facing changes? This adds a `default_acl` option while configuring a s3 operator. This ACL is used when creating a new object. # AI Usage Statement I did not use any AI to code this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
