tisonkun commented on code in PR #7185:
URL: https://github.com/apache/opendal/pull/7185#discussion_r2791093709
##########
core/services/huggingface/src/config.rs:
##########
@@ -20,21 +20,19 @@ use std::fmt::Debug;
use serde::Deserialize;
use serde::Serialize;
-use super::HUGGINGFACE_SCHEME;
-use super::backend::HuggingfaceBuilder;
+use super::backend::HfBuilder;
+use super::uri::HfUri;
+use super::uri::RepoType;
/// Configuration for Huggingface service support.
#[derive(Default, Serialize, Deserialize, Clone, PartialEq, Eq)]
#[serde(default)]
#[non_exhaustive]
-pub struct HuggingfaceConfig {
+pub struct HfConfig {
Review Comment:
You can open one now. We can merge it, and you can rebase this PR onto that
merged one. Then we have fewer changesets to review.
I have no strong feelings about either name. But this can be a breaking
change that needs to be documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
