tisonkun commented on code in PR #689:
URL: https://github.com/apache/opendal-reqsign/pull/689#discussion_r2853673159
##########
Cargo.toml:
##########
@@ -52,6 +52,7 @@ hex = "0.4"
hmac = "0.12"
http = "1"
jiff = "0.2"
+jsonwebtoken = { version = "10", features = ["aws_lc_rs"] }
Review Comment:
> and other dependencies of opendal-reqsign already require aws_lc_rs
Yes. This is mainly pulled in from `reqwest 0.13`'s `default-tls`.
We may have a follow-up to investigate whether we can make it optional
(switchable between aws-lc-rs and ring).
I personally don't like aws-lc-rs too much since it pulls in `cmake` and
other build hazards. But it's the trend, and I don't find too many motivations
to build a replacement now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
