svn commit: r579046 - /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java

[djencks]

Author: djencks
Date: Mon Sep 24 21:05:07 2007
New Revision: 579046

URL: http://svn.apache.org/viewvc?rev=579046&view=rev
Log:
GERONIMO-3481, there may be no running OpenEjbConfiguration so avoid NPEs, and 
allow construction of ConfigurationFactory with a known sys configuration.

Modified:
    
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java?rev=579046&r1=579045&r2=579046&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
 Mon Sep 24 21:05:07 2007
@@ -101,6 +101,11 @@
         this(false);
     }
 
+    public ConfigurationFactory(boolean offline, OpenEjbConfiguration 
configuration) {
+        this(offline);
+        sys = configuration;
+    }
+
     public static class Chain implements DynamicDeployer{
         private final List<DynamicDeployer> chain = new 
ArrayList<DynamicDeployer>();
 
@@ -670,9 +675,11 @@
         List<String> resourceIds = new ArrayList<String>();
 
         OpenEjbConfiguration runningConfig = getRunningConfig();
-        for (ResourceInfo resourceInfo : runningConfig.facilities.resources) {
-            if (isResourceType(resourceInfo.service, resourceInfo.types, 
type)) {
-                resourceIds.add(resourceInfo.id);
+        if (runningConfig != null) {
+            for (ResourceInfo resourceInfo : 
runningConfig.facilities.resources) {
+                if (isResourceType(resourceInfo.service, resourceInfo.types, 
type)) {
+                    resourceIds.add(resourceInfo.id);
+                }
             }
         }
 
@@ -744,8 +751,10 @@
         List<ContainerInfo> containers = new ArrayList<ContainerInfo>();
 
         OpenEjbConfiguration runningConfig = getRunningConfig();
-        for (ContainerInfo containerInfo : 
runningConfig.containerSystem.containers) {
-            containers.add(containerInfo);
+        if (runningConfig != null) {
+            for (ContainerInfo containerInfo : 
runningConfig.containerSystem.containers) {
+                containers.add(containerInfo);
+            }
         }
 
         if (sys != null) {