Author: jlaskowski
Date: Sun Jan  6 14:09:22 2008
New Revision: 609434

URL: http://svn.apache.org/viewvc?rev=609434&view=rev
Log:
House-keeping for messages:
o Lower message importance as some should be at debug level
o Introduce message keys for some msgs


Modified:
    
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
    
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityEjbHomeHandler.java
    
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java
    
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
    
openejb/trunk/openejb3/container/openejb-core/src/main/resources/embedded.logging.properties
    
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/assembler/classic/Messages.properties
    
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/util/resources/Messages.properties

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
 Sun Jan  6 14:09:22 2008
@@ -303,7 +303,7 @@
                     }
                     finder = new ClassFinder(ejbModule.getClassLoader(), url);
                 } catch (MalformedURLException e) {
-                    DeploymentLoader.logger.warning("Unable to scrape for 
@Stateful, @Stateless or @MessageDriven annotations. EjbModule URL not valid: " 
+ ejbModule.getJarLocation());
+                    
DeploymentLoader.logger.warning("startup.scrapeFailedForModule", 
ejbModule.getJarLocation());
                     return ejbModule;
                 }
             } else {

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityEjbHomeHandler.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityEjbHomeHandler.java?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityEjbHomeHandler.java
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityEjbHomeHandler.java
 Sun Jan  6 14:09:22 2008
@@ -52,11 +52,11 @@
     }
 
     protected Object findX(Class interfce, Method method, Object[] args, 
Object proxy) throws Throwable {
-        Object retValue = null;
+        Object retValue;
         try {
             retValue = container.invoke(deploymentID, interfce, method, args, 
null);
         } catch (OpenEJBException e) {
-            e.printStackTrace();
+            logger.debug("entityEjbHomeHandler.containerInvocationFailure", e, 
e.getMessage());
             throw e;
         }
 

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java
 Sun Jan  6 14:09:22 2008
@@ -43,7 +43,7 @@
 import org.apache.openejb.util.proxy.ProxyManager;
 
 public abstract class EjbHomeProxyHandler extends BaseEjbProxyHandler {
-    private static final Logger logger = 
Logger.getInstance(LogCategory.OPENEJB, "org.apache.openejb.util.resources");
+    public static final Logger logger = 
Logger.getInstance(LogCategory.OPENEJB, "org.apache.openejb.util.resources");
 
     private final Map<String, MethodType> dispatchTable;
 

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
 Sun Jan  6 14:09:22 2008
@@ -216,8 +216,7 @@
     }
 
     protected void logSystemException(Throwable sysException) {
-
-        logger.error("The bean instances business method encountered a system 
exception: " + sysException.getMessage(), sysException);
+        logger.debug("startup.beanInstanceSystemExceptionThrown", 
sysException, sysException.getMessage());
     }
 
     protected void discardBeanInstance(Object instance, ThreadContext 
callContext) {

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/embedded.logging.properties
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/resources/embedded.logging.properties?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/embedded.logging.properties
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/embedded.logging.properties
 Sun Jan  6 14:09:22 2008
@@ -53,7 +53,7 @@
 log4j.category.OpenEJB.startup     = info
 log4j.category.OpenEJB.startup.config = info
 log4j.category.OpenEJB.hsql        = info
-log4j.category.CORBA-Adapter       = debug
+log4j.category.CORBA-Adapter       = info
 log4j.category.Transaction         = warn
 log4j.category.org.apache.activemq = error
 log4j.category.org.apache.geronimo = error

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/assembler/classic/Messages.properties
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/assembler/classic/Messages.properties?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/assembler/classic/Messages.properties
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/assembler/classic/Messages.properties
 Sun Jan  6 14:09:22 2008
@@ -20,8 +20,7 @@
 # Assembler.PersistenceClassLoaderHandlerImpl
 # addTransformer(ClassLoader, ClassFileTransformer)
 # error("assembler.noAgent");
-assembler.noAgent = JAVA AGENT NOT INSTALLED.  The JPA Persistence Provider 
requested installation of a ClassFileTransformer which requires a JavaAgent.  
See http://openejb.apache.org/3.0/javaagent.html
-
+assembler.noAgent = JAVA AGENT NOT INSTALLED. The JPA Persistence Provider 
requested installation of a ClassFileTransformer which requires a JavaAgent.  
See http://openejb.apache.org/3.0/javaagent.html
 
 # PersistenceBuilder.java
 # logger.info("assembler.buildingPersistenceUnit", 
unitInfo.getPersistenceUnitName(), unitInfo.getPersistenceProviderClassName(), 
unitInfo.getPersistenceUnitRootUrl(), unitInfo.getTransactionType());
@@ -71,7 +70,6 @@
 # info("createResource.createConnectionManager", serviceInfo.id, 
service.getClass().getName());
 createResource.createConnectionManager = Creating ConnectionManager for 
Resource(id={0})
 
-
 # destroyApplication(AppInfo)
 # info("destroyApplication.start", appInfo.jarPath);
 destroyApplication.start = Undeploying app: {0}
@@ -89,7 +87,6 @@
 # error("appCreationEvent.failed", e, listenerName, appInfo.jarPath);
 appCreationEvent.failed = Error notifying deployment listener {0} of created 
application {1}
 
-
 # fireBeforeApplicationDestroyed(AppInfo)
 # debug("appDestroyedEvent.start", listenerName, appInfo.jarPath);
 appDestroyedEvent.start = App Destroyed Event: {0}: {1}
@@ -101,6 +98,5 @@
 # error("removeContainer.unbindFailed", containerId);
 removeContainer.unbindFailed = Failed to unbind {0}
 
-
 # warning("unusedProperty", property, info.id);
-unusedProperty = Property "{0} not supported by "{1}"
\ No newline at end of file
+unusedProperty = Property "{0}" not supported by "{1}"
\ No newline at end of file

Modified: 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/util/resources/Messages.properties
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/util/resources/Messages.properties?rev=609434&r1=609433&r2=609434&view=diff
==============================================================================
--- 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/util/resources/Messages.properties
 (original)
+++ 
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/util/resources/Messages.properties
 Sun Jan  6 14:09:22 2008
@@ -42,6 +42,8 @@
 startup.transactionManager=TransactionManager: {0}
 startup.ready=OpenEJB ready.
 startup.noContainersConfigured=Attemtped to access containers where none are 
configured.
+startup.scrapeFailedForModule=Unable to scrape for @Stateful, @Stateless or 
@MessageDriven annotations. Invalid EjbModule URL: {0}
+startup.beanInstanceSystemExceptionThrown=The bean instance business method 
encountered a system exception: {0}
 
 #
 # Error code prefixes:
@@ -247,3 +249,5 @@
 deploy.c.050=Deploy option -c.  Could not copy jar {0}. A security exception 
occurred while attempting to copy the jar to the default beans directory {1}. 
Exception message: {2}
 deploy.c.060=Deploy option -c.  Could not copy jar {0} to {1}. Received 
exception: {2}: {3}
 deploy.c.061=Deploy option -c.  Could not copy jar {0} to {1}. Jar already 
exists.  Use -f option to force an overwrite.
+
+entityEjbHomeHandler.containerInvocationFailure=Failure at container 
invocation: {0}
\ No newline at end of file


Reply via email to