Author: rmannibucau
Date: Thu Sep 27 12:52:17 2012
New Revision: 1390973

URL: http://svn.apache.org/viewvc?rev=1390973&view=rev
Log:
TOMEE-432 TOMEE-433 jndi subtree for @Resource resolution + arquillian adapter 
host/command for shutdown

Modified:
    
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEConfiguration.java
    
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEContainer.java
    
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AutoConfig.java
    
openejb/trunk/openejb/examples/multiple-tomee-arquillian/src/test/resources/arquillian.xml

Modified: 
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEConfiguration.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEConfiguration.java?rev=1390973&r1=1390972&r2=1390973&view=diff
==============================================================================
--- 
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEConfiguration.java
 (original)
+++ 
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEConfiguration.java
 Thu Sep 27 12:52:17 2012
@@ -31,6 +31,8 @@ public class TomEEConfiguration implemen
     protected String dir = System.getProperty("java.io.tmpdir") + 
"/arquillian-apache-tomee";
     protected String appWorkingDir = System.getProperty("java.io.tmpdir");
     protected String host = "localhost";
+    protected String stopHost = "localhost"; // generally localhost but host 
(http) can be different
+    protected String stopCommand = "SHUTDOWN"; // default one - can be 
overriden in server.xml
     protected String serverXml = null;
     protected String properties = "";
     protected String portRange = ""; // only used if port < 0, empty means 
whatever, can be "1024-65535"
@@ -141,4 +143,20 @@ public class TomEEConfiguration implemen
         }
         return array;
     }
+
+    public String getStopHost() {
+        return stopHost;
+    }
+
+    public void setStopHost(String stopHost) {
+        this.stopHost = stopHost;
+    }
+
+    public String getStopCommand() {
+        return stopCommand + Character.toString((char) -1); // last char to 
avoid warning/error log message
+    }
+
+    public void setStopCommand(String stopCommand) {
+        this.stopCommand = stopCommand;
+    }
 }

Modified: 
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEContainer.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEContainer.java?rev=1390973&r1=1390972&r2=1390973&view=diff
==============================================================================
--- 
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEContainer.java
 (original)
+++ 
openejb/trunk/openejb/arquillian/arquillian-tomee-common/src/main/java/org/apache/openejb/arquillian/common/TomEEContainer.java
 Thu Sep 27 12:52:17 2012
@@ -54,7 +54,6 @@ import java.util.logging.Logger;
 public abstract class TomEEContainer<Configuration extends TomEEConfiguration> 
implements DeployableContainer<Configuration> {
     protected static final Logger LOGGER = 
Logger.getLogger(TomEEContainer.class.getName());
 
-    protected static final String SHUTDOWN_COMMAND = "SHUTDOWN" + 
Character.toString((char) -1);
     protected Configuration configuration;
     protected Map<String, DeployedApp> moduleIds = new HashMap<String, 
DeployedApp>();
     private final Options options;
@@ -191,9 +190,9 @@ public abstract class TomEEContainer<Con
     @Override
     public void stop() throws LifecycleException {
         try {
-            Socket socket = new Socket(configuration.getHost(), 
configuration.getStopPort());
+            Socket socket = new Socket(configuration.getStopHost(), 
configuration.getStopPort());
             OutputStream out = socket.getOutputStream();
-            out.write(SHUTDOWN_COMMAND.getBytes());
+            out.write(configuration.getStopCommand().getBytes());
 
             waitForShutdown(socket, 10);
         } catch (Exception e) {

Modified: 
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AutoConfig.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AutoConfig.java?rev=1390973&r1=1390972&r2=1390973&view=diff
==============================================================================
--- 
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AutoConfig.java
 (original)
+++ 
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AutoConfig.java
 Thu Sep 27 12:52:17 2012
@@ -1829,6 +1829,10 @@ public class AutoConfig implements Dynam
     private String normalizeResourceId(String resourceId) {
         if (resourceId == null) return null;
 
+        if (resourceId.startsWith("comp/env/")) {
+            resourceId = resourceId.substring("comp/env/".length());
+        }
+
         // strip off "java:comp/env"
         if (resourceId.startsWith("java:comp/env/")) {
             resourceId = resourceId.substring("java:comp/env/".length());

Modified: 
openejb/trunk/openejb/examples/multiple-tomee-arquillian/src/test/resources/arquillian.xml
URL: 
http://svn.apache.org/viewvc/openejb/trunk/openejb/examples/multiple-tomee-arquillian/src/test/resources/arquillian.xml?rev=1390973&r1=1390972&r2=1390973&view=diff
==============================================================================
--- 
openejb/trunk/openejb/examples/multiple-tomee-arquillian/src/test/resources/arquillian.xml
 (original)
+++ 
openejb/trunk/openejb/examples/multiple-tomee-arquillian/src/test/resources/arquillian.xml
 Thu Sep 27 12:52:17 2012
@@ -25,6 +25,7 @@
         <property name="ajpPort">-1</property>
         <property name="version">${tomee.version}</property>
         <property name="dir">target/apache-tomee-remote-1</property>
+        <property name="conf">m</property>
         <property 
name="appWorkingDir">target/arquillian-test-working-dir-1</property>
       </configuration>
     </container>
@@ -39,4 +40,4 @@
       </configuration>
     </container>
   </group>
-</arquillian>
\ No newline at end of file
+</arquillian>


Reply via email to